From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
Olga Kornievskaia <olga.kornievskaia@gmail.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH v3 0/6] fstests: copy_file_range() tests
Date: Sun, 2 Jun 2019 15:41:08 +0300 [thread overview]
Message-ID: <20190602124114.26810-1-amir73il@gmail.com> (raw)
Eryu,
This is a re-work of Dave Chinner's copy_file_range() tests which
I used to verify the kernel fixes of the syscall [1].
The 2 first tests fix bugs in the interface, so they are appropriate
for merge IMO.
The cross-device copy test checks a new functionality, so you may
want to wait with merging it till after the work is merged upstream.
The bounds check test depend on a change that was only posted to
xfsprogs [2]. Without two changes that were merge to xfsprogs v4.20,
the original test (v1, v2) would hang. Requiring the new copy_range
flag (copy_range -f) mitigates this problem.
You may want to wait until the xfs_io change is merged before merging
the check for the new flag.
Thanks,
Amir.
[1] https://lore.kernel.org/linux-fsdevel/20190531164701.15112-1-amir73il@gmail.com/
[2] https://marc.info/?l=linux-xfs&m=155912482124038&w=2
Changes from v2:
- Change blockdev in test to loop and _require_loop (Olga)
- Implement and use _require_xfs_io_command copy_range -f
Changes from v1:
- Remove patch to test EINVAL behavior instead of short copy
- Remove 'chmod -r' permission drop test case
- Split out test for swap/immutable file copy
- Split of cross-device copy test
Amir Goldstein (6):
generic: create copy_range group
generic: copy_file_range immutable file test
generic: copy_file_range swapfile test
common/rc: check support for xfs_io copy_range -f N
generic: copy_file_range bounds test
generic: cross-device copy_file_range test
common/rc | 9 ++-
tests/generic/434 | 2 +
tests/generic/988 | 59 +++++++++++++++++++
tests/generic/988.out | 5 ++
tests/generic/989 | 56 ++++++++++++++++++
tests/generic/989.out | 4 ++
tests/generic/990 | 132 ++++++++++++++++++++++++++++++++++++++++++
tests/generic/990.out | 37 ++++++++++++
tests/generic/991 | 56 ++++++++++++++++++
tests/generic/991.out | 4 ++
tests/generic/group | 14 +++--
11 files changed, 372 insertions(+), 6 deletions(-)
create mode 100755 tests/generic/988
create mode 100644 tests/generic/988.out
create mode 100755 tests/generic/989
create mode 100644 tests/generic/989.out
create mode 100755 tests/generic/990
create mode 100644 tests/generic/990.out
create mode 100755 tests/generic/991
create mode 100644 tests/generic/991.out
--
2.17.1
next reply other threads:[~2019-06-02 12:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 12:41 Amir Goldstein [this message]
2019-06-02 12:41 ` [PATCH v3 1/6] generic: create copy_range group Amir Goldstein
2019-06-02 12:41 ` [PATCH v3 2/6] generic: copy_file_range immutable file test Amir Goldstein
2019-06-07 17:10 ` Eryu Guan
2019-06-02 12:41 ` [PATCH v3 3/6] generic: copy_file_range swapfile test Amir Goldstein
2019-06-10 3:58 ` Theodore Ts'o
2019-06-10 6:37 ` Amir Goldstein
2019-06-10 9:08 ` Amir Goldstein
2019-06-10 13:31 ` Theodore Ts'o
2019-06-10 16:06 ` Darrick J. Wong
2019-06-10 16:54 ` Amir Goldstein
2019-06-10 17:04 ` Darrick J. Wong
2019-06-11 2:13 ` Eryu Guan
2019-06-11 2:12 ` Eryu Guan
2019-06-11 2:36 ` Eryu Guan
2019-06-02 12:41 ` [PATCH v3 4/6] common/rc: check support for xfs_io copy_range -f N Amir Goldstein
2019-06-02 12:41 ` [PATCH v3 5/6] generic: copy_file_range bounds test Amir Goldstein
2019-06-02 12:41 ` [PATCH v3 6/6] generic: cross-device copy_file_range test Amir Goldstein
2019-06-09 13:46 ` [PATCH v3 0/6] fstests: copy_file_range() tests Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190602124114.26810-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox