Re: [PATCH v3 2/2] shared/012: Add tests for filename casefolding feature

Gabriel Krisman Bertazi
2019-06-12T18:32:10Z

"Theodore Ts'o" <tytso@mit.edu> writes:

> On Wed, Jun 12, 2019 at 01:01:46AM -0400, Gabriel Krisman Bertazi wrote:
>> > I tried out this test, and it's apparently failing for me using
>> > e2fsprogs 1.45.2; it looks like it's a whitespace issue?
>>
>> Hi Ted,
>>
>> Yes, definitely just whitespace. But i don't understand why you are
>> getting this behavior. I tried both with the master branch of e2fsprogs
>> and the tagged commit of v1.45.2 and on both occasions the test succeed
>> in my system. For sure I can use filter_spaces but I'm puzzled why I
>> can't reproduce this.
>
> That's wierd. The kvm-xfstests appliance VM that's uploaded to
>
> https://mirrors.edge.kernel.org/pub/linux/kernel/people/tytso/kvm-xfstests/
>
> shows the problem. With your patch applied to the xfstests-dev
> directory after checking out xfstests-bld (see [1] for more
> information if you haven't used kvm-xfstests before), it's reproducible via:
>
> kvm-xfstests -I ../out_dir/root_fs.img.amd64 --update-xfstests-tar -c 4k shared/012
>
> [1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md

Hi,

Thanks for the tip. With my setup, I still can't reproduce it, but I
was able to trigger it with xfstests-bld. I'll send a follow up patch
that makes the result deterministic, making it work for every scenario.
Later, I'll take a look to see what is missing on my setup to make it
trigger.

--
Gabriel Krisman Bertazi