From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: fstests@vger.kernel.org, linux-unionfs@vger.kernel.org,
miklos@szeredi.hu
Subject: Re: [PATCH] generic/486: filter out irrelevant attrs
Date: Thu, 27 Jun 2019 08:25:36 -0700 [thread overview]
Message-ID: <20190627152536.GA5167@magnolia> (raw)
In-Reply-To: <20190627090100.18542-1-jencce.kernel@gmail.com>
On Thu, Jun 27, 2019 at 05:00:59PM +0800, Murphy Zhou wrote:
> In some setup, there could be extra attrs printed, like selinux.
> They are breaking golden output and irrelevant for this test.
> So focus on the attr we are testing on to avoid false alarm.
> Print the output to .full for debug.
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/generic/486 | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/generic/486 b/tests/generic/486
> index ff115a07..ea571efe 100755
> --- a/tests/generic/486
> +++ b/tests/generic/486
> @@ -46,10 +46,12 @@ _scratch_mkfs >>$seqres.full 2>&1
> _scratch_mount >>$seqres.full 2>&1
>
> filter_attr_output() {
> - _filter_scratch | sed -e 's/has a [0-9]* byte value/has a NNNN byte value/g'
> + _filter_scratch | grep world | \
> + sed -e 's/has a [0-9]* byte value/has a NNNN byte value/g'
> }
>
> ./src/attr_replace_test $SCRATCH_MNT/hello
> +$ATTR_PROG -l $SCRATCH_MNT/hello >>$seqres.full 2>&1
> $ATTR_PROG -l $SCRATCH_MNT/hello | filter_attr_output
>
> status=0
> --
> 2.21.0
>
prev parent reply other threads:[~2019-06-27 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 9:00 [PATCH] generic/486: filter out irrelevant attrs Murphy Zhou
2019-06-27 15:25 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627152536.GA5167@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=jencce.kernel@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox