public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH v2 2/5] check: add ext4 group list when testing ext2 and ext3
Date: Fri, 28 Jun 2019 18:59:07 -0400	[thread overview]
Message-ID: <20190628225910.17018-2-tytso@mit.edu> (raw)
In-Reply-To: <20190628225910.17018-1-tytso@mit.edu>

Modern kernels use the ext4 implementation to support ext2 and ext3
mounts, and a number of the ext4 tests are actually suitable for ext2
and ext3.  We're trying to move tests out of shared anyway, so instead
of moving tests from ext4/NNN to shared, let's just include the ext4
group list when FSTYP is ext2 or ext3.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
Changes since v1:
   - none

 check | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/check b/check
index 7511e1ce..2a5d8ab1 100755
--- a/check
+++ b/check
@@ -130,6 +130,7 @@ get_group_list()
 	local grp=$1
 	local grpl=""
 	local sub=$(dirname $grp)
+	local fsgroup="$FSTYP"
 
 	if [ -n "$sub" -a "$sub" != "." -a -d "$SRC_DIR/$sub" ]; then
 		# group is given as <subdir>/<group> (e.g. xfs/quick)
@@ -138,7 +139,10 @@ get_group_list()
 		return
 	fi
 
-	for d in $SRC_GROUPS $FSTYP; do
+	if [ "$FSTYP" = ext2 -o "$FSTYP" = ext3 ]; then
+	    fsgroup=ext4
+	fi
+	for d in $SRC_GROUPS $fsgroup; do
 		if ! test -d "$SRC_DIR/$d" ; then
 			continue
 		fi
-- 
2.22.0

  reply	other threads:[~2019-06-28 22:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 22:59 [PATCH v2 1/5] shared,ext4: move ext4-specific tests out of shared/ Theodore Ts'o
2019-06-28 22:59 ` Theodore Ts'o [this message]
2019-06-28 22:59 ` [PATCH v2 3/5] shared,ext4: move ext[234]-specific " Theodore Ts'o
2019-06-28 22:59 ` [PATCH v2 4/5] shared,generic: move shared/006 to generic/ Theodore Ts'o
2019-07-05  8:07   ` Eryu Guan
2019-07-06  3:40     ` Theodore Ts'o
2019-07-07 12:51       ` Eryu Guan
2019-06-28 22:59 ` [PATCH v2 5/5] shared,generic: move tests using duperemove " Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628225910.17018-2-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox