From: Chao Yu <yuchao0@huawei.com>
To: guaneryu@gmail.com
Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
jaegeuk@kernel.org, chao@kernel.orga,
Chao Yu <yuchao0@huawei.com>
Subject: [PATCH 1/3] generic/38[3456]: adjust to check prjquota before mount
Date: Tue, 23 Jul 2019 17:25:27 +0800 [thread overview]
Message-ID: <20190723092529.112426-1-yuchao0@huawei.com> (raw)
Move _require_prjquota() to front of _qmount() since we do the
check on device directly instead of mountpoint, it can avoid
potential failure if filesystem utils needs exclusive open on
device.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
tests/generic/383 | 2 +-
tests/generic/384 | 2 +-
tests/generic/385 | 2 +-
tests/generic/386 | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/generic/383 b/tests/generic/383
index 2c8c5923..cf5ac255 100755
--- a/tests/generic/383
+++ b/tests/generic/383
@@ -39,6 +39,7 @@ _require_xfs_quota_foreign
_scratch_mkfs >/dev/null 2>&1
_scratch_enable_pquota
+_require_prjquota $SCRATCH_DEV
do_project_test()
{
@@ -76,7 +77,6 @@ EOF
# Test project
_qmount_option "usrquota,prjquota"
_qmount
-_require_prjquota $SCRATCH_DEV
do_project_test
# success, all done
diff --git a/tests/generic/384 b/tests/generic/384
index b7c940d7..2c0cd00b 100755
--- a/tests/generic/384
+++ b/tests/generic/384
@@ -57,10 +57,10 @@ chmod a+rwx $seqres.full # arbitrary users will write here
_require_scratch
_scratch_mkfs >/dev/null 2>&1
_scratch_enable_pquota
+_require_prjquota $SCRATCH_DEV
_qmount_option "prjquota"
_qmount
-_require_prjquota $SCRATCH_DEV
report_quota()
{
diff --git a/tests/generic/385 b/tests/generic/385
index 937131a9..56ce6eb0 100755
--- a/tests/generic/385
+++ b/tests/generic/385
@@ -56,9 +56,9 @@ quota_cmd="$XFS_QUOTA_PROG -D $tmp.projects -P $tmp.projid"
_scratch_mkfs >/dev/null 2>&1
_scratch_enable_pquota
+_require_prjquota $SCRATCH_DEV
_qmount_option "prjquota"
_qmount
-_require_prjquota $SCRATCH_DEV
#
# Create the project root
diff --git a/tests/generic/386 b/tests/generic/386
index 462c5869..e4f7d23b 100755
--- a/tests/generic/386
+++ b/tests/generic/386
@@ -112,10 +112,10 @@ echo $proj_num:$proj_dir > "$my_projects"
_scratch_mkfs >> "$seqres.full" 2>&1
_scratch_enable_pquota
+_require_prjquota $SCRATCH_DEV
_qmount_option "prjquota"
_qmount
-_require_prjquota $SCRATCH_DEV
mkdir -p "${proj_dir}"
--
2.18.0.rc1
next reply other threads:[~2019-07-23 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 9:25 Chao Yu [this message]
2019-07-23 9:25 ` [PATCH 2/3] common/quota: support f2fs in _require_quota() and _check_quota_usage() Chao Yu
2019-07-23 9:25 ` [PATCH 3/3] common/rc: check quota sysfile feature for f2fs Chao Yu
2019-07-28 9:51 ` [PATCH 1/3] generic/38[3456]: adjust to check prjquota before mount Eryu Guan
2019-07-29 11:43 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723092529.112426-1-yuchao0@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.orga \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox