From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
To: guaneryu@gmail.com, darrick.wong@oracle.com
Cc: ruansy.fnst@cn.fujitsu.com, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: [PATCH] common/rc: check 'chattr +/-x' on dax device.
Date: Tue, 30 Jul 2019 16:40:09 +0800 [thread overview]
Message-ID: <20190730084009.26257-1-ruansy.fnst@cn.fujitsu.com> (raw)
'chattr +/-x' only works on a dax device. When checking if the 'x'
attribute is supported by XFS_IO_PROG:
_require_xfs_io_command "chattr" "x" (called by xfs/260)
it's better to do the check on a dax device mounted with dax option.
Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
---
common/rc | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/common/rc b/common/rc
index e0b087c1..73ee5563 100644
--- a/common/rc
+++ b/common/rc
@@ -2094,11 +2094,22 @@ _require_xfs_io_command()
if [ -z "$param" ]; then
param=s
fi
+
+ # Attribute "x" should be tested on a dax device
+ if [ "$param" == "x" ]; then
+ _scratch_mount "-o dax"
+ testfile=$SCRATCH_MNT/$$.xfs_io
+ fi
+
# Test xfs_io chattr support AND
# filesystem FS_IOC_FSSETXATTR support
testio=`$XFS_IO_PROG -F -f -c "chattr +$param" $testfile 2>&1`
$XFS_IO_PROG -F -f -r -c "chattr -$param" $testfile 2>&1
param_checked="+$param"
+
+ if [ "$param" == "x" ]; then
+ _scratch_unmount
+ fi
;;
"chproj")
testio=`$XFS_IO_PROG -F -f -c "chproj 0" $testfile 2>&1`
--
2.17.0
next reply other threads:[~2019-07-30 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 8:40 Shiyang Ruan [this message]
2019-07-30 14:47 ` [PATCH] common/rc: check 'chattr +/-x' on dax device Darrick J. Wong
2019-07-31 2:08 ` Shiyang Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730084009.26257-1-ruansy.fnst@cn.fujitsu.com \
--to=ruansy.fnst@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox