From: Josef Bacik <josef@toxicpanda.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH] fstests: generic/500 doesn't work for btrfs
Date: Thu, 15 Aug 2019 14:26:59 -0400 [thread overview]
Message-ID: <20190815182659.27875-1-josef@toxicpanda.com> (raw)
Btrfs does COW, so when we unlink the file we need to update metadata
and write it to a new location, which we can't do because the thinp is
full. This results in an EIO during a metadata write, which makes us
flip read only, thus making it impossible to fstrim the fs. Just make
it so we skip this test for btrfs.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
tests/generic/500 | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/generic/500 b/tests/generic/500
index 201d8b9f..5cd7126f 100755
--- a/tests/generic/500
+++ b/tests/generic/500
@@ -49,6 +49,12 @@ _supported_os Linux
_require_scratch_nocheck
_require_dm_target thin-pool
+# The unlink below will result in new metadata blocks for btrfs because of CoW,
+# and since we've filled the thinp device it'll return EIO, which will make
+# btrfs flip read only, making it fail this test when it just won't work right
+# for us in the first place.
+test $FSTYP == "btrfs" && _notrun "btrfs doesn't work that way lol"
+
# Require underlying device support discard
_scratch_mkfs >>$seqres.full 2>&1
_scratch_mount
--
2.21.0
next reply other threads:[~2019-08-15 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:26 Josef Bacik [this message]
2019-08-16 2:16 ` [PATCH] fstests: generic/500 doesn't work for btrfs Darrick J. Wong
2019-08-18 15:44 ` Eryu Guan
2019-08-19 16:25 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815182659.27875-1-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox