From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH][xfstests-bld] build-all: fix acl tools build
Date: Sat, 21 Sep 2019 10:13:12 -0400 [thread overview]
Message-ID: <20190921141312.GA26913@mit.edu> (raw)
In-Reply-To: <20190920184846.18251-1-amir73il@gmail.com>
On Fri, Sep 20, 2019 at 09:48:46PM +0300, Amir Goldstein wrote:
> On a clean do-all buster image getfacl is dynamically
> linked with libacl.so.1, but the built library is not installed.
> The installed libacl.so.1 in the image is incompatible with the
> version of acl tools that we build:
So I did a clean build of a4df7d7b3112: "Update the default version of
quota and xfsprogs" in buster, and the resulting getfacl executable
does not depend on libacl.so.1:
<tytso@stretch-amd64-CHROOT.lambda> {/tmp/xfstests-bld}
1002% ldd xfstests/bin/getfacl
linux-vdso.so.1 (0x00007ffeafbc4000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd8cf9a0000)
/lib64/ld-linux-x86-64.so.2 (0x00007fd8cff47000)
Is there something in your config.custom which is influencing the
reseult? I'm also not seeing any file in the acl directory, after the
build, which contains NO_SOLIB:
<tytso@stretch-amd64-CHROOT.lambda> {/tmp/xfstests-bld/acl}
1004% find . -type f -print | xargs grep NO_SOLIB
The git repository for keyutils does respect NO_SOLIB, but that's
because it's hard-coded into keyutils's Makefile. So it doesn't
appear to me how your change would make any difference to how the acl
library is built.
Can you take a closer look?
- Ted
next prev parent reply other threads:[~2019-09-21 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:48 [PATCH][xfstests-bld] build-all: fix acl tools build Amir Goldstein
2019-09-20 18:51 ` Amir Goldstein
2019-09-20 23:41 ` Theodore Y. Ts'o
2019-09-21 14:13 ` Theodore Y. Ts'o [this message]
2019-09-21 15:37 ` Amir Goldstein
2019-09-21 21:35 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190921141312.GA26913@mit.edu \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox