From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga07-in.huawei.com ([45.249.212.35]:56926 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725992AbfI0KIE (ORCPT ); Fri, 27 Sep 2019 06:08:04 -0400 From: Chao Yu Subject: [PATCH] common/rc: generalize _get_filesize() Date: Fri, 27 Sep 2019 18:07:42 +0800 Message-ID: <20190927100742.9266-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Sender: fstests-owner@vger.kernel.org To: guaneryu@gmail.com Cc: fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Chao Yu List-ID: There are some testcases use below command to get file size, generalize it as global function _get_filesize() ls -l $1 | $AWK_PROG '{print $5}' - adjust common/defrag, generic/275 and generic/315 to use it - remove unused _filesize in generic/013 Signed-off-by: Chao Yu --- common/defrag | 2 +- common/rc | 5 +++++ tests/generic/013 | 5 ----- tests/generic/275 | 2 +- tests/generic/315 | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/common/defrag b/common/defrag index 9866d3da..50596f70 100644 --- a/common/defrag +++ b/common/defrag @@ -145,7 +145,7 @@ _defrag() STAT_BEFORE=`stat -c "a: %x m: %y c: %z" $1` if [ $FSTYP == "f2fs" ]; then - _filesize=`ls -l $1 | $AWK_PROG '{print $5}'` + _filesize=`_get_filesize $1` $DEFRAG_PROG 0 $_filesize $1 >> $seqres.full 2>&1 else $DEFRAG_PROG -v $1 >> $seqres.full 2>&1 diff --git a/common/rc b/common/rc index 66c7fd4d..69735ae6 100644 --- a/common/rc +++ b/common/rc @@ -165,6 +165,11 @@ if [ ! -z "$REPORT_LIST" ]; then _assert_report_list fi +_get_filesize() +{ + echo `ls -l $1 | $AWK_PROG '{print $5}'` +} + _mount() { $MOUNT_PROG `_mount_ops_filter $*` diff --git a/tests/generic/013 b/tests/generic/013 index 9e533ee8..bc596102 100755 --- a/tests/generic/013 +++ b/tests/generic/013 @@ -24,11 +24,6 @@ _cleanup() rm -rf $TEST_DIR/fsstress.$$.* } -_filesize() -{ - ls -l $1 | $AWK_PROG '{print " filesize = " $5}' -} - # get standard environment, filters and checks . ./common/rc . ./common/filter diff --git a/tests/generic/275 b/tests/generic/275 index a934c19c..adc82856 100755 --- a/tests/generic/275 +++ b/tests/generic/275 @@ -73,7 +73,7 @@ echo "Bytes written until ENOSPC:" >>$seqres.full du $SCRATCH_MNT/tmp1 >>$seqres.full # And at least some of it should succeed. -_filesize=`ls -l $SCRATCH_MNT/tmp1 | awk '{print $5}'` +_filesize=`_get_filesize $SCRATCH_MNT/tmp1` [ $_filesize -lt $((128 * 1024)) ] && \ _fail "Partial write until enospc failed; wrote $_filesize bytes." diff --git a/tests/generic/315 b/tests/generic/315 index fd49b579..808d7d74 100755 --- a/tests/generic/315 +++ b/tests/generic/315 @@ -52,7 +52,7 @@ $XFS_IO_PROG -f -c 'falloc -k 0 $(($avail_begin/2))' \ $TEST_DIR/testfile.$seq >>$seqres.full 2>&1 # Verify the file size, it should keep unchanged as 0 in this case -fsize=`ls -l $TEST_DIR/testfile.$seq | awk '{print $5}'` +fsize=`_get_filesize $TEST_DIR/testfile.$seq` [ "$fsize" -eq 0 ] || _fail "File size is changed to ($fsize Bytes)" # Truncate the file size back to 0 -- 2.18.0.rc1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FFBC4360C for ; Fri, 27 Sep 2019 10:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4A94217F4 for ; Fri, 27 Sep 2019 10:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbfI0KIE (ORCPT ); Fri, 27 Sep 2019 06:08:04 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:56926 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725992AbfI0KIE (ORCPT ); Fri, 27 Sep 2019 06:08:04 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id DD07883C419AF77F4883; Fri, 27 Sep 2019 18:08:01 +0800 (CST) Received: from szvp000203569.huawei.com (10.120.216.130) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Fri, 27 Sep 2019 18:07:48 +0800 From: Chao Yu To: CC: , , "Chao Yu" Subject: [PATCH] common/rc: generalize _get_filesize() Date: Fri, 27 Sep 2019 18:07:42 +0800 Message-ID: <20190927100742.9266-1-yuchao0@huawei.com> X-Mailer: git-send-email 2.18.0.rc1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [10.120.216.130] X-CFilter-Loop: Reflected Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Message-ID: <20190927100742.kEJjjXCQxtZ1k1qY6YGxuFM3DOZGA2m0x4O5kw6PXv4@z> There are some testcases use below command to get file size, generalize it as global function _get_filesize() ls -l $1 | $AWK_PROG '{print $5}' - adjust common/defrag, generic/275 and generic/315 to use it - remove unused _filesize in generic/013 Signed-off-by: Chao Yu --- common/defrag | 2 +- common/rc | 5 +++++ tests/generic/013 | 5 ----- tests/generic/275 | 2 +- tests/generic/315 | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/common/defrag b/common/defrag index 9866d3da..50596f70 100644 --- a/common/defrag +++ b/common/defrag @@ -145,7 +145,7 @@ _defrag() STAT_BEFORE=`stat -c "a: %x m: %y c: %z" $1` if [ $FSTYP == "f2fs" ]; then - _filesize=`ls -l $1 | $AWK_PROG '{print $5}'` + _filesize=`_get_filesize $1` $DEFRAG_PROG 0 $_filesize $1 >> $seqres.full 2>&1 else $DEFRAG_PROG -v $1 >> $seqres.full 2>&1 diff --git a/common/rc b/common/rc index 66c7fd4d..69735ae6 100644 --- a/common/rc +++ b/common/rc @@ -165,6 +165,11 @@ if [ ! -z "$REPORT_LIST" ]; then _assert_report_list fi +_get_filesize() +{ + echo `ls -l $1 | $AWK_PROG '{print $5}'` +} + _mount() { $MOUNT_PROG `_mount_ops_filter $*` diff --git a/tests/generic/013 b/tests/generic/013 index 9e533ee8..bc596102 100755 --- a/tests/generic/013 +++ b/tests/generic/013 @@ -24,11 +24,6 @@ _cleanup() rm -rf $TEST_DIR/fsstress.$$.* } -_filesize() -{ - ls -l $1 | $AWK_PROG '{print " filesize = " $5}' -} - # get standard environment, filters and checks . ./common/rc . ./common/filter diff --git a/tests/generic/275 b/tests/generic/275 index a934c19c..adc82856 100755 --- a/tests/generic/275 +++ b/tests/generic/275 @@ -73,7 +73,7 @@ echo "Bytes written until ENOSPC:" >>$seqres.full du $SCRATCH_MNT/tmp1 >>$seqres.full # And at least some of it should succeed. -_filesize=`ls -l $SCRATCH_MNT/tmp1 | awk '{print $5}'` +_filesize=`_get_filesize $SCRATCH_MNT/tmp1` [ $_filesize -lt $((128 * 1024)) ] && \ _fail "Partial write until enospc failed; wrote $_filesize bytes." diff --git a/tests/generic/315 b/tests/generic/315 index fd49b579..808d7d74 100755 --- a/tests/generic/315 +++ b/tests/generic/315 @@ -52,7 +52,7 @@ $XFS_IO_PROG -f -c 'falloc -k 0 $(($avail_begin/2))' \ $TEST_DIR/testfile.$seq >>$seqres.full 2>&1 # Verify the file size, it should keep unchanged as 0 in this case -fsize=`ls -l $TEST_DIR/testfile.$seq | awk '{print $5}'` +fsize=`_get_filesize $TEST_DIR/testfile.$seq` [ "$fsize" -eq 0 ] || _fail "File size is changed to ($fsize Bytes)" # Truncate the file size back to 0 -- 2.18.0.rc1