Re: [PATCH] xfs/191-input-validation:Fix issue that the test takes too long

Darrick J. Wong
2019-11-26T15:36:47Z

On Tue, Nov 26, 2019 at 05:23:36AM +0000, Baihua Lu wrote:
> In this test, we don't need to check filesystem on the scratch device for there is not
> really creating the file system. If _check_filesystems executes, xfs_logprint will be
> failed for having dirty log and xfs_repaire will take a long time.

Where did the dirty log come from if we didn't actually format anything?
I thought I had taught fstests to wipefs the scratch device between
each test...

(No objections to the diff itself, I'm simply curious about the commit
message.)

--D

>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
> ---
> tests/xfs/191-input-validation | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
> # Modify as appropriate.
> _supported_fs xfs
> _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
> _require_xfs_mkfs_validation
>
>
> --
> 2.17.1
>