From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Baihua Lu <lubaihua0331@gmail.com>
Cc: fstests@vger.kernel.org, guaneryu@gmail.com, balu@microsoft.com,
Lili.Deng@microsoft.com
Subject: Re: [PATCH] xfs/191-input-validation:Fix issue that the test takes too long
Date: Tue, 26 Nov 2019 07:36:37 -0800 [thread overview]
Message-ID: <20191126153637.GF6212@magnolia> (raw)
In-Reply-To: <20191126052336.98489-1-lubaihua0331@gmail.com>
On Tue, Nov 26, 2019 at 05:23:36AM +0000, Baihua Lu wrote:
> In this test, we don't need to check filesystem on the scratch device for there is not
> really creating the file system. If _check_filesystems executes, xfs_logprint will be
> failed for having dirty log and xfs_repaire will take a long time.
Where did the dirty log come from if we didn't actually format anything?
I thought I had taught fstests to wipefs the scratch device between
each test...
(No objections to the diff itself, I'm simply curious about the commit
message.)
--D
>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
> ---
> tests/xfs/191-input-validation | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index b6658015..db427349 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -31,7 +31,7 @@ _cleanup()
> # Modify as appropriate.
> _supported_fs xfs
> _supported_os Linux
> -_require_scratch
> +_require_scratch_nocheck
> _require_xfs_mkfs_validation
>
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-11-26 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 5:23 [PATCH] xfs/191-input-validation:Fix issue that the test takes too long Baihua Lu
2019-11-26 15:36 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-27 10:41 Baihua Lu
2019-11-27 16:31 ` Darrick J. Wong
2019-11-20 8:17 Baihua Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126153637.GF6212@magnolia \
--to=darrick.wong@oracle.com \
--cc=Lili.Deng@microsoft.com \
--cc=balu@microsoft.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=lubaihua0331@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox