From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Baihua Lu <lubaihua0331@gmail.com>
Cc: fstests@vger.kernel.org, guaneryu@gmail.com, balu@microsoft.com,
Lili.Deng@microsoft.com
Subject: Re: [PATCH] xfs/191-input-validation:The "verion=1 -m crc=1" option is valid
Date: Wed, 4 Dec 2019 23:05:01 -0800 [thread overview]
Message-ID: <20191205070501.GA13252@magnolia> (raw)
In-Reply-To: <20191205040236.26066-1-lubaihua0331@gmail.com>
On Thu, Dec 05, 2019 at 04:02:36AM +0000, Baihua Lu wrote:
> The "version=1 -m crc=1" option is valid, so the test should be passed.
# mkfs.xfs -l version=1 -m crc=1 /dev/sda1
V2 logs always enabled for CRC enabled filesystems
Usage: mkfs.xfs
/* blocksize */ [-b size=num]
<other junk>
That's a pass?
<confused>
--D
>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
> ---
> tests/xfs/191-input-validation | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation
> index db427349..b5611c5b 100755
> --- a/tests/xfs/191-input-validation
> +++ b/tests/xfs/191-input-validation
> @@ -217,6 +217,7 @@ do_mkfs_pass -l lazy-count=1 -m crc=0 $SCRATCH_DEV
> do_mkfs_pass -l version=1 -m crc=0 $SCRATCH_DEV
> do_mkfs_pass -l version=2 -m crc=0 $SCRATCH_DEV
> do_mkfs_pass -l version=2 $SCRATCH_DEV
> +do_mkfs_pass -l version=1 -m crc=1 $SCRATCH_DEV
>
> # log section, should fail
> do_mkfs_fail -l size=${fssize}b $SCRATCH_DEV
> @@ -239,7 +240,6 @@ do_mkfs_fail -l internal=1,logdev=$fsimg $SCRATCH_DEV
> do_mkfs_fail -l lazy-count=1garbage $SCRATCH_DEV
> do_mkfs_fail -l lazy-count=2 $SCRATCH_DEV
> do_mkfs_fail -l lazy-count=0 -m crc=1 $SCRATCH_DEV
> -do_mkfs_fail -l version=1 -m crc=1 $SCRATCH_DEV
> do_mkfs_fail -l version=0 $SCRATCH_DEV
>
>
> --
> 2.17.1
>
prev parent reply other threads:[~2019-12-05 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 4:02 [PATCH] xfs/191-input-validation:The "verion=1 -m crc=1" option is valid Baihua Lu
2019-12-05 7:05 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205070501.GA13252@magnolia \
--to=darrick.wong@oracle.com \
--cc=Lili.Deng@microsoft.com \
--cc=balu@microsoft.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=lubaihua0331@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox