public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <lhenriques@suse.com>
To: Eryu Guan <guaneryu@gmail.com>, Omar Sandoval <osandov@osandov.com>
Cc: fstests@vger.kernel.org, Luis Henriques <lhenriques@suse.com>
Subject: [PATCH] generic/590: add _require_xfs_io_command "falloc"
Date: Mon,  9 Dec 2019 17:14:52 +0000	[thread overview]
Message-ID: <20191209171452.16170-1-lhenriques@suse.com> (raw)

Without this check the test will fail with message:

  fallocate: Operation not supported

Instead, with this _require_xfs_io_command, the test will be skipped
instead if falloc isn't supported.

Signed-off-by: Luis Henriques <lhenriques@suse.com>
---
 tests/generic/590 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/generic/590 b/tests/generic/590
index 80a665c6b001..2670fe99d21f 100755
--- a/tests/generic/590
+++ b/tests/generic/590
@@ -34,6 +34,7 @@ rm -f $seqres.full
 _supported_fs generic
 _supported_os Linux
 _require_scratch_nocheck
+_require_xfs_io_command "falloc"
 
 maxextlen=$((0x1fffff))
 bs=4096

             reply	other threads:[~2019-12-09 17:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 17:14 Luis Henriques [this message]
2019-12-10 18:42 ` [PATCH] generic/590: add _require_xfs_io_command "falloc" Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209171452.16170-1-lhenriques@suse.com \
    --to=lhenriques@suse.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox