From: Eryu Guan <guaneryu@gmail.com>
To: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
fstests@vger.kernel.org
Subject: Re: [PATCH] common/filter: prepend 0 to treat offset as octal
Date: Mon, 16 Dec 2019 00:08:30 +0800 [thread overview]
Message-ID: <20191215160828.GB1776323@desktop> (raw)
In-Reply-To: <20191212100009818.MNNO.12766.ppp.dion.ne.jp@dmta0006.auone-net.jp>
On Thu, Dec 12, 2019 at 07:00:09PM +0900, Kusanagi Kouichi wrote:
> On 2019-12-11 22:04:37 -0800, Darrick J. Wong wrote:
> > On Thu, Dec 12, 2019 at 12:11:52PM +0900, Naohiro Aota wrote:
> > > The offsets printed by "od" are octal numbers. So, we need to add "0" at
> > > the head of the $offset to parse it as an octal number.
> > >
> > > Fixes: 37520a314bd4 ("fstests: Don't use gawk's strtonum")
> > > Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> >
> > <grumble> Did the original patch author run all the tests that use
> > _filter_od to make sure there weren't any regressions. This fixes
> > xfs/139 for me, so...
>
> I'm sorry. I didn't test well. Eryu, can you revert commit 37520a314bd4?
Sure, I'll just revert it for now.
Eryu
next prev parent reply other threads:[~2019-12-15 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 3:11 [PATCH] common/filter: prepend 0 to treat offset as octal Naohiro Aota
2019-12-12 6:04 ` Darrick J. Wong
2019-12-12 6:10 ` Darrick J. Wong
2019-12-12 10:00 ` Kusanagi Kouichi
2019-12-15 16:08 ` Eryu Guan [this message]
2019-12-15 16:07 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191215160828.GB1776323@desktop \
--to=guaneryu@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=slash@ac.auone-net.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox