From: Omar Sandoval <osandov@osandov.com>
To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc: kernel-team@fb.com
Subject: Re: [PATCH fstests] btrfs: add test for large direct I/O reads w/ RAID
Date: Mon, 2 Mar 2020 18:03:21 -0800 [thread overview]
Message-ID: <20200303020321.GA215148@vader> (raw)
In-Reply-To: <f9a293a382e81ba55e2a321634cb1548d7f69627.1583186857.git.osandov@fb.com>
On Mon, Mar 02, 2020 at 02:08:45PM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Apparently we don't have any tests which exercise the code path in Btrfs
> that has to split up direct I/Os for RAID stripes. Add one to catch the
> bug fixed by "btrfs: fix RAID direct I/O reads with alternate csums".
> ---
> I also had to fix up the tests/btrfs/group file, which had a renumbering
> issue that was preventing me from adding a new test.
>
> tests/btrfs/207 | 58 +++++++++++++++++++++++++++++++++++++++++++++
> tests/btrfs/207.out | 2 ++
> tests/btrfs/group | 3 ++-
> 3 files changed, 62 insertions(+), 1 deletion(-)
> create mode 100755 tests/btrfs/207
> create mode 100644 tests/btrfs/207.out
>
> diff --git a/tests/btrfs/207 b/tests/btrfs/207
> new file mode 100755
> index 00000000..99e57cb8
> --- /dev/null
> +++ b/tests/btrfs/207
> @@ -0,0 +1,58 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2020 Facebook. All Rights Reserved.
> +#
> +# FS QA Test 207
> +#
> +# Test large DIO reads with various profiles. Regression test for patch "btrfs:
> +# fix RAID direct I/O reads with alternate csums".
Hmm, I might as well make this test also exercise direct I/O writes, not
just reads. I'll send a v2.
next prev parent reply other threads:[~2020-03-03 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 22:08 [PATCH fstests] btrfs: add test for large direct I/O reads w/ RAID Omar Sandoval
2020-03-03 2:03 ` Omar Sandoval [this message]
2020-03-03 2:51 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303020321.GA215148@vader \
--to=osandov@osandov.com \
--cc=fstests@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox