Re: [PATCH] xfs/513: fix allocsize on archs with pagesize larger than blocksize

[Anthony Iliopoulos <ailiopoulos@suse.com>]

On Sat, Mar 07, 2020 at 03:15:12PM +0800, Zorro Lang wrote:
> On Sat, Mar 07, 2020 at 01:44:07AM +0100, Anthony Iliopoulos wrote:
> > The minimum accepted allocsize mount option value is page size, which
> > causes the particular test to fail in architectures where page size >
> > block size. Fix it by basing the value on the platform page size rather
> > than the block size as obtained from mkfs. In addition add a filter so
> > that different values can be used without breaking the golden output.
> > 
> > Signed-off-by: Anthony Iliopoulos <ailiopoulos@suse.com>
> > ---
> 
> Hi,
> 
> Thanks for this patch, I've forgotten that I tried to fix it:
> https://marc.info/?l=fstests&m=158250811523489&w=2
> 
> And looks like Eryu prefer filtering the PAGESIZE, he might like to merge
> this one:)

I missed that, but assumed that the intention of the test was to cover
the minimum allowable value on the allocsize range and not just the
parsing, so I made it variable. Either way it's fine as long as the test
covers the intended purpose.

> The patch looks good to me, only one slight thing. The filter_pagesz() is
> not used to filter "$pagesize" itself, it filters "allocsize=$pagesize"
> actually. So how about name it as filter_xfs_options (or something like that),
> then we might add more lines(filter) in it later?

Thanks for the review, yes this makes sense, so I'll send a v2 shortly
with the changes.