FS/XFS testing framework
 help / color / mirror / Atom feed
From: Yong Sun <sunyong0511@gmail.com>
To: fstests@vger.kernel.org
Cc: Yong Sun <yosun@suse.com>
Subject: [PATCH] fstests: modify user name beginning with non-digit
Date: Wed,  3 Jun 2020 18:20:36 +0800	[thread overview]
Message-ID: <20200603102035.552-1-yosun@suse.com> (raw)

openSUSE and SLE don't support username begin with digit, so it will
skip test generic/597 and generic/598 by lack of 123456-fsgqa user.
generic/597 and 598 are not test username begin with digit on purpose
(different with generic/381). It's will be helpful to use an username
begin with non-digit in this case.

Signed-off-by: Sun Yong <yosun@suse.com>
---
 README            | 1 +
 tests/generic/597 | 4 ++--
 tests/generic/598 | 4 ++--
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/README b/README
index 094a7742..cffa0bc6 100644
--- a/README
+++ b/README
@@ -22,6 +22,7 @@ _______________________
 - create fsgqa test user ("sudo useradd -m fsgqa")
 - create fsgqa group ("sudo groupadd fsgqa")
 - create 123456-fsgqa test user ("sudo useradd 123456-fsgqa")
+- create fsgqa-123456 test user ("sudo useradd fsgqa-123456")
 
 ______________________
 USING THE FSQA SUITE
diff --git a/tests/generic/597 b/tests/generic/597
index 1d87a23a..c4d524b7 100755
--- a/tests/generic/597
+++ b/tests/generic/597
@@ -43,11 +43,11 @@ _require_sysctl_variable fs.protected_symlinks
 _require_sysctl_variable fs.protected_hardlinks
 # su in _require_user prints warnings about user name starts with a digit,
 # discard the warning
-_require_user 123456-fsgqa >/dev/null 2>&1
+_require_user fsgqa-123456 >/dev/null 2>&1
 # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account
 _require_user fsgqa
 
-OWNER=123456-fsgqa
+OWNER=fsgqa-123456
 OTHER=fsgqa
 
 # Save current system state to reset when done
diff --git a/tests/generic/598 b/tests/generic/598
index 998b62cf..1cf9a3d1 100755
--- a/tests/generic/598
+++ b/tests/generic/598
@@ -43,11 +43,11 @@ _require_sysctl_variable fs.protected_regular
 _require_sysctl_variable fs.protected_fifos
 # su in _require_user prints warnings about user name starts with a digit,
 # discard the warning
-_require_user 123456-fsgqa >/dev/null 2>&1
+_require_user fsgqa-123456 >/dev/null 2>&1
 # Do this SECOND so that qa_user is fsgqa, and _user_do uses that account
 _require_user fsgqa
 
-USER1=123456-fsgqa
+USER1=fsgqa-123456
 USER2=fsgqa
 
 # Save current system state to reset when done
-- 
2.26.2


             reply	other threads:[~2020-06-03 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 10:20 Yong Sun [this message]
2020-06-04  8:30 ` [PATCH] fstests: modify user name beginning with non-digit Petr Vorel
2020-06-04  9:36   ` Zorro Lang
2020-06-04 10:49     ` Petr Vorel
2020-06-04  9:47   ` Sun Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200603102035.552-1-yosun@suse.com \
    --to=sunyong0511@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=yosun@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox