Re: [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file

Christoph Hellwig
2020-09-14T07:26:18Z

On Mon, Sep 14, 2020 at 01:13:59PM +0800, Xiao Yang wrote:
> 'tPnE' flags are only valid for a directory so check them on a directory.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

The change looks good, but I wonder if we should split the chattr
tests into

_require_chattr_file_flag

and

_require_chattr_dir_flag

to make the whole thing a little less convoluted..