Re: [PATCH 03/24] generic/607: don't break on filesystems that don't support FSGETXATTR on dirs

Darrick J. Wong
2020-09-17T16:03:19Z

On Thu, Sep 17, 2020 at 08:52:45AM +0100, Christoph Hellwig wrote:
> On Wed, Sep 16, 2020 at 08:56:20PM -0700, Darrick J. Wong wrote:
> > Oops, sorry, I was reading the wrong VM report. It's overlayfs (atop
> > xfs though I don't think that matters) that doesn't support FSGETXATTR
> > on directories.
>
> I think we should overlayfs to support FSGETXATTR on all files that
> can be opened instead.

Heh, yes, that would be a better option. :)

Even if they do add it, though, I still think we need to be able to
_notrun this test to avoid failures on unpatched kernels?

This also makes me wonder, we lose all the FSGETXATTR state on copy-up,
don't we? Since the VFS doesn't have a primitive for cloning all the
metadata?

--D