Re: [PATCH 04/24] xfs: skip tests that rely on allocation behaviors of the data device

Zorro Lang
2020-09-16T01:50:12Z

On Mon, Sep 14, 2020 at 06:43:21PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> A large number of xfs-specific tests rely on specific behaviors of the
> data device allocator, such as fragmenting free space, carefully curated
> inode and free space counts, or features like filestreams that only
> exist on the data device.
>
> These tests fail horribly if the test runner specified rtinherit=1 on
> the mkfs command line, so skip them all.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

> tests/xfs/171 | 1 +
> tests/xfs/172 | 1 +
> tests/xfs/173 | 1 +
> tests/xfs/174 | 1 +
> tests/xfs/205 | 1 +
> tests/xfs/306 | 1 +
> tests/xfs/318 | 1 +
> tests/xfs/444 | 1 +
> 8 files changed, 8 insertions(+)
>
>
> diff --git a/tests/xfs/171 b/tests/xfs/171
> index 050d02ab..a0d6e3f9 100755
> --- a/tests/xfs/171
> +++ b/tests/xfs/171
> @@ -33,6 +33,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_scratch
> +_require_no_rtinherit
>
> _check_filestreams_support || _notrun "filestreams not available"
>
> diff --git a/tests/xfs/172 b/tests/xfs/172
> index c100481c..13f1f381 100755
> --- a/tests/xfs/172
> +++ b/tests/xfs/172
> @@ -33,6 +33,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_scratch
> +_require_no_rtinherit
>
> _check_filestreams_support || _notrun "filestreams not available"
>
> diff --git a/tests/xfs/173 b/tests/xfs/173
> index 1569146f..47e1d029 100755
> --- a/tests/xfs/173
> +++ b/tests/xfs/173
> @@ -33,6 +33,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_scratch
> +_require_no_rtinherit
>
> _check_filestreams_support || _notrun "filestreams not available"
>
> diff --git a/tests/xfs/174 b/tests/xfs/174
> index 781a1967..348f38c3 100755
> --- a/tests/xfs/174
> +++ b/tests/xfs/174
> @@ -33,6 +33,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_scratch
> +_require_no_rtinherit
>
> _check_filestreams_support || _notrun "filestreams not available"
>
> diff --git a/tests/xfs/205 b/tests/xfs/205
> index 645e509a..6f1c2058 100755
> --- a/tests/xfs/205
> +++ b/tests/xfs/205
> @@ -24,6 +24,7 @@ _supported_os Linux
>
> # single AG will cause xfs_repair to fail checks.
> _require_scratch_nocheck
> +_require_no_rtinherit
>
> rm -f $seqres.full
>
> diff --git a/tests/xfs/306 b/tests/xfs/306
> index edbb6076..d2a0dd7f 100755
> --- a/tests/xfs/306
> +++ b/tests/xfs/306
> @@ -35,6 +35,7 @@ _supported_fs xfs
> _supported_os Linux
>
> _require_scratch_nocheck # check complains about single AG fs
> +_require_no_rtinherit
> _require_xfs_io_command "fpunch"
> _require_command $UUIDGEN_PROG uuidgen
>
> diff --git a/tests/xfs/318 b/tests/xfs/318
> index 83b858ea..a45301e2 100755
> --- a/tests/xfs/318
> +++ b/tests/xfs/318
> @@ -33,6 +33,7 @@ _supported_fs xfs
> _require_scratch
> _require_error_injection
> _require_xfs_io_error_injection "rmap_finish_one"
> +_require_no_rtinherit
>
> rm -f $seqres.full
>
> diff --git a/tests/xfs/444 b/tests/xfs/444
> index 6ed88715..e84b2cca 100755
> --- a/tests/xfs/444
> +++ b/tests/xfs/444
> @@ -40,6 +40,7 @@ _require_scratch
> _require_test_program "punch-alternating"
> _require_xfs_io_command "falloc"
> _require_xfs_db_write_array
> +_require_no_rtinherit
>
> # This is only a v5 filesystem problem
> _require_scratch_xfs_crc
>