Re: [PATCH 13/24] generic/204: don't flood stdout with ENOSPC messages on an ENOSPC test

Zorro Lang
2020-09-16T04:00:17Z

On Mon, Sep 14, 2020 at 06:44:18PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> This test has been on and off my bad list for many years due to the fact
> that it will spew potentially millions of "No space left on device"
> errors if the file count calculations are wrong. The calculations
> should be correct for the XFS data device, but they don't apply to other
> filesystems.
>
> Therefore, filter out the ENOSPC messages when the files are not going
> to be created on the xfs data device (e.g. ext4, xfs realtime, etc.)
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

> tests/generic/204 | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>
> diff --git a/tests/generic/204 b/tests/generic/204
> index 349f5eff..7250c00a 100755
> --- a/tests/generic/204
> +++ b/tests/generic/204
> @@ -76,9 +76,13 @@ files=$((space / (direntlen + isize + dbsize)))
> echo files $files, resvblks $resv_blks >> $seqres.full
> _scratch_resvblks $resv_blks >> $seqres.full 2>&1
>
> +filter() {
> + test $FSTYP != xfs && sed -e '/No space left on device/d'
> +}
> +
> for i in `seq -w 1 $files`; do
> - echo -n > $SCRATCH_MNT/$i
> - echo XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX > $SCRATCH_MNT/$i
> + (echo -n > $SCRATCH_MNT/$i;
> + echo XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX > $SCRATCH_MNT/$i) 2>&1 | filter
> done
>
> # success, all done
>