From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC35C47095 for ; Wed, 7 Oct 2020 03:48:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A925F214DB for ; Wed, 7 Oct 2020 03:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602042524; bh=utdOvzVHh89b4CpLVpb/B52DJTCKTgZ4TatN41r7vCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ei9Ji3VM4l3VNGrHAK0u3K5tOT8ncd5aTdvzmwmfw/zNXPorCWGuI+y3xCpmNNlZj B+DVd7MWJtt4+yyR6rEhcT083lvlJBUJf8Vg97KqyIvm+9pSGaNfTsGsVmOZgVZF0v vmIH1cxcBQKYPHyTnEW+DJvTXeCnEpR2MtA/TUIA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727343AbgJGDso (ORCPT ); Tue, 6 Oct 2020 23:48:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:45398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727287AbgJGDsb (ORCPT ); Tue, 6 Oct 2020 23:48:31 -0400 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D231208C3; Wed, 7 Oct 2020 03:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602042511; bh=utdOvzVHh89b4CpLVpb/B52DJTCKTgZ4TatN41r7vCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DAaVPOwJ/Oo5GVLzk9uGENtdZtKxJUoCECj95UyceMUuaD19dko63qK5FPJ0xYvZH pAKVj9DaXhWCjJPiqysw5TgaBKd2mEoW5WKs4CXTgaScgMmgfnSbCFukXhjCwI1ueM RNPVtN8K/4Gz3YjOidGulDFCDFo3g2LJKJ30WO5c= Date: Tue, 6 Oct 2020 20:48:29 -0700 From: Eric Biggers To: Jaegeuk Kim , Chao Yu , Daeho Jeong Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 0/5] xfstests: test f2fs compression+encryption Message-ID: <20201007034829.GA912@sol.localdomain> References: <20201001002508.328866-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001002508.328866-1-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Wed, Sep 30, 2020 at 05:25:02PM -0700, Eric Biggers wrote: > Add a test which verifies that encryption is done correctly when a file > on f2fs uses both compression and encryption at the same time. > > Patches 1-4 add prerequisites for the test, while patch 5 adds the > actual test. Patch 2 also fixes a bug which could cause the existing > test generic/602 to fail in extremely rare cases. See the commit > messages for details. > > The new test passes both with and without the inlinecrypt mount option. > It requires CONFIG_F2FS_FS_COMPRESSION=y. > > I'd appreciate the f2fs developers taking a look. > > Note, there is a quirk where the IVs in compressed files are off by one > from the "natural" values. It's still secure, though it made the test > slightly harder to write. I'm not sure how intentional this quirk was. > > Eric Biggers (5): > fscrypt-crypt-util: clean up parsing --block-size and --inode-number > fscrypt-crypt-util: fix IV incrementing for --iv-ino-lblk-32 > fscrypt-crypt-util: add --block-number option > common/f2fs: add _require_scratch_f2fs_compression() > f2fs: verify ciphertext of compressed+encrypted file Jaegeuk, Chao, Daeho: any comments on this? - Eric