From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] generic/402: use _try_scratch_mount instead of _scratch_mount
Date: Fri, 16 Oct 2020 08:33:21 -0700 [thread overview]
Message-ID: <20201016153321.GB9830@magnolia> (raw)
In-Reply-To: <1602840684-25524-2-git-send-email-xuyang2018.jy@cn.fujitsu.com>
On Fri, Oct 16, 2020 at 05:31:24PM +0800, Yang Xu wrote:
> Here will check the return code of mount option. So update it
> to use _try_scratch_mount
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
> tests/generic/402 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/402 b/tests/generic/402
> index 7fc81864..4c940ac4 100755
> --- a/tests/generic/402
> +++ b/tests/generic/402
> @@ -102,7 +102,7 @@ run_test()
> }
>
> _scratch_mkfs &>> $seqres.full 2>&1 || _fail "mkfs failed"
> -_scratch_mount || _fail "scratch mount failed"
> +_try_scratch_mount || _fail "scratch mount failed"
Why not just drop the "|| _fail" part? The message isn't much
more specific than the fail message that _scratch_mount emits.
--D
>
> _require_timestamp_range $SCRATCH_DEV
>
> --
> 2.23.0
>
>
>
next prev parent reply other threads:[~2020-10-16 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 9:31 [PATCH 1/2] xfs/521: use _try_scratch_mount instead of _scratch_mount Yang Xu
2020-10-16 9:31 ` [PATCH 2/2] generic/402: " Yang Xu
2020-10-16 15:33 ` Darrick J. Wong [this message]
2020-10-18 10:10 ` Eryu Guan
2020-10-19 2:05 ` Yang Xu
2020-10-19 3:01 ` [PATCH v2] generic/402: Drop useless fail message Yang Xu
2020-10-19 16:03 ` Darrick J. Wong
2020-10-16 15:32 ` [PATCH 1/2] xfs/521: use _try_scratch_mount instead of _scratch_mount Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016153321.GB9830@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox