Re: [PATCH 2/9] xfs/520: disable external devices

Christoph Hellwig
2020-10-28T21:54:09Z

On Tue, Oct 27, 2020 at 12:01:42PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> This is a regression test for a specific bug that requires a specific
> configuration of the data device. Realtime volumes and external logs
> don't affect the efficacy of the test, but the test can fail mkfs if the
> realtime device is very large.
>
> Therefore, unset USE_EXTERNAL so that we always run this regression
> test, even if the tester enabled realtime.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>