Re: [PATCH 3/3] common/rc: source common/xfs and common/btrfs

Darrick J. Wong
2020-10-30T01:57:30Z

On Fri, Oct 30, 2020 at 01:22:53AM +0530, Ritesh Harjani wrote:
> Without this patch I am unable to test for multiple different
> filesystem sections for the same tests. Since we anyway have only
> function definitions in these files, so it should be ok to source it
> by default too.
> e.g. when I run ./check -s btrfs tests/generic/613 with 3 different [***_fs]
> sections from local.config file, I see below failures.
>
> ./common/rc: line 2801: _check_btrfs_filesystem: command not found
>
> ./check -s xfs_4k -g swap (for XFS this fails like below)
> ./common/rc: line 749: _scratch_mkfs_xfs: command not found
> check: failed to mkfs $SCRATCH_DEV using specified options
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> common/rc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/common/rc b/common/rc
> index 4c59968a6bd3..e9ba1b6e8265 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3,6 +3,8 @@
> # Copyright (c) 2000-2006 Silicon Graphics, Inc. All Rights Reserved.
>
> . common/config
> +. ./common/xfs
> +. ./common/btrfs

Uhh, what happens if you run xfs and nfs one after the other?

--D

>
> BC=$(which bc 2> /dev/null) || BC=
>
> --
> 2.26.2
>