From: Eryu Guan <guan@eryu.me>
To: Jeff Layton <jlayton@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common/rc: allow setting $SCRATCH_FS_MOUNT_OPTS
Date: Sun, 8 Nov 2020 14:37:01 +0800 [thread overview]
Message-ID: <20201108063701.GG3853@desktop> (raw)
In-Reply-To: <20201105150936.410407-1-jlayton@kernel.org>
On Thu, Nov 05, 2020 at 10:09:36AM -0500, Jeff Layton wrote:
> We already have a $TEST_FS_MOUNT_OPTS which gets applied only to the
> test mount, but we don't have a corresponding variable for the scratch
> mount. Add one.
MOUNT_OPTIONS is used for the scratch mount, and
_common_dev_mount_options includes it. Would you please confirm if that
works for you?
Thanks,
Eryu
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 65ebfe201139..23874d1e5b8e 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -308,7 +308,7 @@ _scratch_mount_options()
> {
> _scratch_options mount
>
> - echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS \
> + echo `_common_dev_mount_options $*` $SCRATCH_OPTIONS $SCRATCH_FS_MOUNT_OPTS \
> $SCRATCH_DEV $SCRATCH_MNT
> }
>
> --
> 2.28.0
next prev parent reply other threads:[~2020-11-08 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:09 [PATCH] common/rc: allow setting $SCRATCH_FS_MOUNT_OPTS Jeff Layton
2020-11-08 6:37 ` Eryu Guan [this message]
2020-11-09 18:56 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201108063701.GG3853@desktop \
--to=guan@eryu.me \
--cc=fstests@vger.kernel.org \
--cc=jlayton@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox