From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: test mkfs.xfs config files
Date: Mon, 18 Jan 2021 10:18:48 +1100 [thread overview]
Message-ID: <20210117231848.GB78965@dread.disaster.area> (raw)
In-Reply-To: <20210116014607.GE3134581@magnolia>
On Fri, Jan 15, 2021 at 05:46:07PM -0800, Darrick J. Wong wrote:
> On Thu, Oct 29, 2020 at 02:27:13PM -0700, Darrick J. Wong wrote:
> > On Wed, Oct 28, 2020 at 07:54:50AM +1100, Dave Chinner wrote:
> > > +echo End of line comment
> > > +test_mkfs_config << ENDL
> > > +[metadata]
> > > +crc = 0 ; This is an eol comment.
> >
> > Hey, wait a minute, the manpage didn't say I could use semicolon
> > comments! :)
> >
> > The libinih page https://github.com/benhoyt/inih says you can though.
> >
> > Would you mind making a note of that in patch 5 above, please?
>
> Ping? The mkfs code has been merged upstream; we ought to land the
> functionality tests.
Nothing in this patch needs to change, AFAIA, because you were
referring to the xfsprogs mkfs patchset in your comment. So this
is really only waiting on review, right? Do I need to repost it?
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-01-17 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 20:54 [PATCH] xfs: test mkfs.xfs config files Dave Chinner
2020-10-29 21:27 ` Darrick J. Wong
2021-01-16 1:46 ` Darrick J. Wong
2021-01-17 23:18 ` Dave Chinner [this message]
2021-01-18 4:27 ` Darrick J. Wong
2021-01-24 13:33 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210117231848.GB78965@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox