Re: [PATCH 4/6] check: don't abort on non-existent excluded groups

Brian Foster
2021-02-11T14:05:12Z

On Tue, Feb 09, 2021 at 06:56:42PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Don't abort the whole test run if we asked to exclude groups that aren't
> included in the candidate group list, since we actually /are/ satisfying
> the user's request.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> check | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/check b/check
> index e51cbede..6f8db858 100755
> --- a/check
> +++ b/check
> @@ -243,7 +243,7 @@ _prepare_test_list()
> list=$(get_group_list $xgroup)
> if [ -z "$list" ]; then
> echo "Group \"$xgroup\" is empty or not defined?"
> - exit 1
> + continue
> fi

Is this only for a nonexistent group? I.e., 'check -x nosuchgroup ...' ?
If so, what's the advantage?

Brian

>
> trim_test_list $list
>