From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9946C433E0 for ; Sun, 14 Mar 2021 15:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B847964E75 for ; Sun, 14 Mar 2021 15:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbhCNPbR (ORCPT ); Sun, 14 Mar 2021 11:31:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37320 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233841AbhCNPa4 (ORCPT ); Sun, 14 Mar 2021 11:30:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615735855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vFfjUG3a+M2OD6DVpvhxpcboX6c4yQzbwJRL6s4bW6k=; b=O69HyW6SRKY77NaTBQLqJpa8mZjXmFMDj7tSquO5vNLFTYaSuBkYVrnudE2iwhpf58yDuj jKApYfcmdMR6vT0Ek7a6IZ+Ds28T6+uV0AzBMJlA+Kz/K5oxcRwStX8qfNOnAnBVEJMYtg Zu/zxv+lIpUOYTXpwKcWEJIDVymHx6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-UuhOQ0SCPViYsSDcoym-3Q-1; Sun, 14 Mar 2021 11:30:53 -0400 X-MC-Unique: UuhOQ0SCPViYsSDcoym-3Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C49F8100C618; Sun, 14 Mar 2021 15:30:52 +0000 (UTC) Received: from localhost (unknown [10.66.61.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A6585C5DF; Sun, 14 Mar 2021 15:30:51 +0000 (UTC) Date: Sun, 14 Mar 2021 23:49:20 +0800 From: Zorro Lang To: Eryu Guan Cc: fstests@vger.kernel.org Subject: Re: [PATCH] generic/095: don't silence fio error output Message-ID: <20210314154920.GN3499219@localhost.localdomain> Mail-Followup-To: Eryu Guan , fstests@vger.kernel.org References: <20210202062253.24478-1-zlang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Sun, Mar 14, 2021 at 07:36:32PM +0800, Eryu Guan wrote: > Hi Zorro, > > On Tue, Feb 02, 2021 at 02:22:53PM +0800, Zorro Lang wrote: > > This case print both fio stdout and stderr to .full file, that cause > > we miss some unexpected failures when there's a bug. For example: > > > > file:io_u.c:1803, func=io_u error, error=Block device required > > > > This's an regression issue we find on a downstream kernel, not in > > upstream. So release unexpected fio error output to find more issues. > > > > Signed-off-by: Zorro Lang > > --- > > tests/generic/095 | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/tests/generic/095 b/tests/generic/095 > > index 9afaa761..30fe77a5 100755 > > --- a/tests/generic/095 > > +++ b/tests/generic/095 > > @@ -98,8 +98,11 @@ _require_fio $fio_config > > _scratch_mkfs >>$seqres.full 2>&1 > > _scratch_mount > > > > +# There's a known EIO failure to report collisions between directio and buffered > > +# writes to userspace, refer to upstream linux 5a9d929d6e13. So ignore EIO error > > +# at here. > > +$FIO_PROG $fio_config --ignore_error=,EIO --output=$seqres.full > > I found that with this change, EIO is ignored and the return value of > fio command is 0 as expected, but the output breaks golden image and > fails the test. > > [root@fedoravm xfstests]# ./check -s xfs_4k_reflink generic/095 > SECTION -- xfs_4k_reflink > RECREATING -- xfs on /dev/mapper/testvg-lv1 > FSTYP -- xfs (debug) > PLATFORM -- Linux/x86_64 fedoravm 5.11.0 #5 SMP Sun Feb 28 21:50:24 CST 2021 > MKFS_OPTIONS -- -f -f -b size=4k -m reflink=1,rmapbt=1 /dev/mapper/testvg-lv2 > MOUNT_OPTIONS -- /dev/mapper/testvg-lv2 /mnt/scratch > > generic/095 4s ... - output mismatch (see /root/workspace/xfstests/results//xfs_4k_reflink/generic/095.out.bad) > --- tests/generic/095.out 2018-02-25 15:15:00.097388035 +0800 > +++ /root/workspace/xfstests/results//xfs_4k_reflink/generic/095.out.bad 2021-03-14 19:32:04.126884255 +0800 > @@ -1,2 +1,7 @@ > QA output created by 095 > +job9: No I/O performed by mmap, perhaps try --debug=io option for details? > +job9: No I/O performed by mmap, perhaps try --debug=io option for details? > +job9: No I/O performed by mmap, perhaps try --debug=io option for details? > +job9: No I/O performed by mmap, perhaps try --debug=io option for details? > +job9: No I/O performed by mmap, perhaps try --debug=io option for details? > Silence is golden > > Did you hit the same failure? If so I think we should filter out this > message. Hmm... I never hit that. I don't think this patch can cause this error, can you still reproduce it without this patch? The mmap operation from fio might get some unexpected random arguments, you might find a fio bug :-P Thanks, Zorro > > Thanks, > Eryu > > > echo "Silence is golden" > > -$FIO_PROG $fio_config >>$seqres.full 2>&1 > > > > # xfs generates WARNINGs on purpose when applications mix buffered/mmap IO with > > # direct IO on the same file. On the other hand, this fio job has been proven > > -- > > 2.29.2 >