From: "Darrick J. Wong" <djwong@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: fstests@vger.kernel.org, guan@eryu.me, chao@kernel.org
Subject: Re: [PATCH] generic/629: add missing copy_range command check
Date: Mon, 29 Mar 2021 11:44:56 -0700 [thread overview]
Message-ID: <20210329184456.GS1670408@magnolia> (raw)
In-Reply-To: <20210329014013.4953-1-yuchao0@huawei.com>
On Mon, Mar 29, 2021 at 09:40:13AM +0800, Chao Yu wrote:
> Otherwise, if xfs_io doesn't support this command, it will report
> that filesystem fails on this testcase.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
Yep, thanks for catching this.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/generic/629 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/629 b/tests/generic/629
> index ad86ab5bb0c0..13d433a4e470 100755
> --- a/tests/generic/629
> +++ b/tests/generic/629
> @@ -36,6 +36,7 @@ _cleanup()
> _supported_fs generic
> _require_dm_target error
> _require_xfs_io_command "chattr" "s"
> +_require_xfs_io_command "copy_range"
> _require_scratch
>
> rm -f $seqres.full
> --
> 2.29.2
>
prev parent reply other threads:[~2021-03-29 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 1:40 [PATCH] generic/629: add missing copy_range command check Chao Yu
2021-03-29 18:44 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329184456.GS1670408@magnolia \
--to=djwong@kernel.org \
--cc=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox