From: Jakob Unterwurzacher <jakobunt@gmail.com>
To: fstests@vger.kernel.org
Cc: Jakob Unterwurzacher <jakobunt@gmail.com>
Subject: [PATCH] generic/286: fix integer underflow on block sizes != 4096
Date: Sat, 22 May 2021 20:48:14 +0200 [thread overview]
Message-ID: <20210522184814.95802-1-jakobunt@gmail.com> (raw)
The read loop always requested 4096 bytes, which only works
when the total read length is a multiple of 4096 bytes.
This is not neccessarily true, and when it's not, len wraps
around to UINT64_MAX and you get a lot of these:
ERROR: [error:38] reached EOF:Success
This was caught when running xfstests against gocryptfs,
an encrypted overlay file system.
On ext4, the test still passes after this change.
Signed-off-by: Jakob Unterwurzacher <jakobunt@gmail.com>
---
src/seek_copy_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/seek_copy_test.c b/src/seek_copy_test.c
index 0c2c6a3d..28c021e2 100644
--- a/src/seek_copy_test.c
+++ b/src/seek_copy_test.c
@@ -98,7 +98,7 @@ do_extent_copy(int src_fd, int dest_fd, off_t data_off, off_t hole_off)
}
while (len > 0) {
- ssize_t nr_read = read(src_fd, buf, BUF_SIZE);
+ ssize_t nr_read = read(src_fd, buf, MIN(len, BUF_SIZE));
if (nr_read < 0) {
if (errno == EINTR)
continue;
--
2.31.1
next reply other threads:[~2021-05-22 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 18:48 Jakob Unterwurzacher [this message]
2021-05-23 9:05 ` [PATCH] generic/286: fix integer underflow on block sizes != 4096 Eryu Guan
2021-05-25 17:34 ` Jakob Unterwurzacher
2021-05-26 3:20 ` Eryu Guan
2021-05-26 3:41 ` Darrick J. Wong
2021-05-26 8:02 ` Jakob Unterwurzacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210522184814.95802-1-jakobunt@gmail.com \
--to=jakobunt@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox