From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] common/config: remove default 4k blocksize from XFS_MKFS_OPTIONS
Date: Tue, 25 May 2021 09:05:07 -0700 [thread overview]
Message-ID: <20210525160507.GA202095@locust> (raw)
In-Reply-To: <20210525044642.552682-1-zlang@redhat.com>
On Tue, May 25, 2021 at 12:46:41PM +0800, Zorro Lang wrote:
> xfstests set "-bsize=4k" to XFS_MKFS_OPTIONS by default, then give
> it to MKFS_OPTIOPNS. So MKFS_OPTIOPNS always contains "-bsize=4k"
> except we set XFS_MKFS_OPTIONS manually.
>
> It's useless to set XFS_MKFS_OPTIONS to "-bsize=4096" by default,
> especially that will cause all cases with _scratch_mkfs_blocksized()
> always fail as "-b size option respecified", when test on XFS. For
> exmaple: generic/222
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
/me wonders what the historical context is (a) for having an
$FSTYP-specific MKFS_OPTIONS variable, and (b) for setting bsize=4096
here. All I can say is that I've tripped over this numerous times and
wouldn't really mind if it went away. :P
Acked-by: Darrick J. Wong <djwong@kernel.org>
(acked in the sense that I'm not /opposed/ but really really wants to
know the historical reasons)
--D
> ---
> common/config | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/config b/common/config
> index a47e462c..ecd59fae 100644
> --- a/common/config
> +++ b/common/config
> @@ -60,7 +60,6 @@ export EMAIL=root@localhost # where auto-qa will send its status messages
> export HOST_OPTIONS=${HOST_OPTIONS:=local.config}
> export CHECK_OPTIONS=${CHECK_OPTIONS:="-g auto"}
> export BENCH_PASSES=${BENCH_PASSES:=5}
> -export XFS_MKFS_OPTIONS=${XFS_MKFS_OPTIONS:=-bsize=4096}
> export TIME_FACTOR=${TIME_FACTOR:=1}
> export LOAD_FACTOR=${LOAD_FACTOR:=1}
> export DEBUGFS_MNT=${DEBUGFS_MNT:="/sys/kernel/debug"}
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-05-25 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 4:46 [PATCH 1/2] common/config: remove default 4k blocksize from XFS_MKFS_OPTIONS Zorro Lang
2021-05-25 4:46 ` [PATCH 2/2] generic: test small swapfile without page-aligned contiguous blocks Zorro Lang
2021-05-25 16:09 ` Darrick J. Wong
2021-05-26 4:13 ` Zorro Lang
2021-05-27 9:18 ` riteshh
2021-05-25 16:05 ` Darrick J. Wong [this message]
2021-05-30 12:23 ` [PATCH 1/2] common/config: remove default 4k blocksize from XFS_MKFS_OPTIONS Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525160507.GA202095@locust \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox