Re: [PATCH 4/9] generic/317, afs: Allow for a filesystem not to honour the local uid/gid

David Howells
2021-05-25T16:41:28Z

Darrick J. Wong <djwong@kernel.org> wrote:

> > +_require_use_local_uidgid()
>
> I find "local uid" to be misleading here -- I read it as "requires
> system to use local user/group ids", as opposed to getting user and
> group data from an external service like NIS/YP/AD.
>
> What you're really testing for is that new files inherit the fs[ug]id of
> the process. How about we make that explicit in the name:
>
> _require_inherit_process_fsuid()
> _require_inherit_process_fsgid()
>
> ?

Um. I'm not sure "inherit" is the right verb here. Or "require" for that
matter. Would it make more sense to state it differently? Maybe say what is
being checked:

_test_expects_inode_to_get_fsuid
_test_expects_inode_to_get_fsgid

or maybe:

_expects_filesystem_to_set_owner_from_fsuid

though that could also be:

_require_filesystem_to_set_owner_from_fsuid

David