Re: [PATCH 8/9] generic/465: Fix handling of DIO alignment < sizeof(long)

David Howells
2021-05-25T16:46:07Z

Darrick J. Wong <djwong@kernel.org> wrote:

> I wonder if you ought to just change the posix_memalign call to match
> (somewhat more closely) what the other directio testers do:
>
> ret = posix_memalign((void **)&wbuf, sysconf(_SC_PAGESIZE), blksize);
>
> Since the alignment of the memory buffer doesn't necessarily have
> anything to do with the alignment of the read/write offset.

Fine by me, but I don't know if someone specifically wanted it to work like
this.

> (Longer term it would be /really/ nice to hoist DIOINFO to all the
> filesystems, and refactor fstests to use it consistently, but that's way
> too big of a request for this patchset.)

One thing I wanted for fsinfo() it to use the information exported by that to
inform testsuites of what a filesystem's capabilities are.

David