Re: [PATCH 1/2] common/config: remove default 4k blocksize from XFS_MKFS_OPTIONS

Darrick J. Wong
2021-05-25T16:05:11Z

On Tue, May 25, 2021 at 12:46:41PM +0800, Zorro Lang wrote:
> xfstests set "-bsize=4k" to XFS_MKFS_OPTIONS by default, then give
> it to MKFS_OPTIOPNS. So MKFS_OPTIOPNS always contains "-bsize=4k"
> except we set XFS_MKFS_OPTIONS manually.
>
> It's useless to set XFS_MKFS_OPTIONS to "-bsize=4096" by default,
> especially that will cause all cases with _scratch_mkfs_blocksized()
> always fail as "-b size option respecified", when test on XFS. For
> exmaple: generic/222
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>

/me wonders what the historical context is (a) for having an
$FSTYP-specific MKFS_OPTIONS variable, and (b) for setting bsize=4096
here. All I can say is that I've tripped over this numerous times and
wouldn't really mind if it went away. :P

Acked-by: Darrick J. Wong <djwong@kernel.org>

(acked in the sense that I'm not /opposed/ but really really wants to
know the historical reasons)

--D

> ---
> common/config | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/config b/common/config
> index a47e462c..ecd59fae 100644
> --- a/common/config
> +++ b/common/config
> @@ -60,7 +60,6 @@ export EMAIL=root@localhost # where auto-qa will send its status messages
> export HOST_OPTIONS=${HOST_OPTIONS:=local.config}
> export CHECK_OPTIONS=${CHECK_OPTIONS:="-g auto"}
> export BENCH_PASSES=${BENCH_PASSES:=5}
> -export XFS_MKFS_OPTIONS=${XFS_MKFS_OPTIONS:=-bsize=4096}
> export TIME_FACTOR=${TIME_FACTOR:=1}
> export LOAD_FACTOR=${LOAD_FACTOR:=1}
> export DEBUGFS_MNT=${DEBUGFS_MNT:="/sys/kernel/debug"}
> --
> 2.31.1
>