From: Sun Ke <sunke32@huawei.com>
To: <fstests@vger.kernel.org>, <guan@eryu.me>, <yuchao0@huawei.com>
Cc: <sunke32@huawei.com>
Subject: [PATCH] common/rc: f2fs do not support metadata journaling
Date: Fri, 11 Jun 2021 19:22:09 +0800 [thread overview]
Message-ID: <20210611112211.1408767-1-sunke32@huawei.com> (raw)
In generic/50, touch 100 files, go down the fs immediately, Then umount
and set the disk readi-only. Try to mount it again without \-o
norecovery\, it should fail, because it can not recovery on a read-only
device. But f2fs mount successfully and the test fail.
f2fs seems do not support metadata journaling.
Signed-off-by: Sun Ke <sunke32@huawei.com>
---
I am not very sure if f2fs do not support metadata journaling.
###
before change
###
[root@localhost xfstests-dev]# ./check tests/generic/050
FSTYP -- f2fs
PLATFORM -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021
MKFS_OPTIONS -- /dev/sdb
MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
generic/050 4s ... - output mismatch (see /root/work/xfstests-dev/results//generic/050.out.bad)
--- tests/generic/050.out 2021-05-31 15:37:40.000000000 +0800
+++ /root/work/xfstests-dev/results//generic/050.out.bad 2021-06-11 16:48:19.993000000 +0800
@@ -13,9 +13,7 @@
setting device read-only
mounting filesystem that needs recovery on a read-only device:
mount: device write-protected, mounting read-only
-mount: cannot mount device read-only
unmounting read-only filesystem
-umount: SCRATCH_DEV: not mounted
mounting filesystem with -o norecovery on a read-only device:
...
(Run 'diff -u /root/work/xfstests-dev/tests/generic/050.out /root/work/xfstests-dev/results//generic/050.out.bad' to see the entire diff)
Ran: generic/050
Failures: generic/050
Failed 1 of 1 tests
###
after change
###
[root@localhost xfstests-dev]# ./check tests/generic/050
FSTYP -- f2fs
PLATFORM -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021
MKFS_OPTIONS -- /dev/sdb
MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
generic/050 4s ... 4s
Ran: generic/050
Passed all 1 tests
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index a0aa7300..428b8b80 100644
--- a/common/rc
+++ b/common/rc
@@ -3543,7 +3543,7 @@ _has_metadata_journaling()
fi
case "$FSTYP" in
- ext2|vfat|msdos|udf|exfat|tmpfs)
+ ext2|vfat|msdos|udf|exfat|tmpfs|f2fs)
echo "$FSTYP does not support metadata journaling"
return 1
;;
--
2.13.6
next reply other threads:[~2021-06-11 11:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 11:22 Sun Ke [this message]
2021-06-11 11:22 ` [PATCH] generic/103: leave more space for f2fs Sun Ke
2021-06-13 14:44 ` Eryu Guan
2021-06-15 3:36 ` Sun Ke
2021-06-15 3:28 ` Sun Ke
2021-06-16 13:15 ` [f2fs-dev] " Chao Yu
2021-06-17 6:22 ` Sun Ke
2021-06-11 11:22 ` [PATCH] generic/260: f2fs is also special Sun Ke
2021-06-15 3:29 ` Sun Ke
2021-06-16 13:43 ` [f2fs-dev] " Chao Yu
2021-06-17 6:38 ` Sun Ke
2021-06-15 3:25 ` [PATCH] common/rc: f2fs do not support metadata journaling Sun Ke
2021-06-16 12:36 ` [f2fs-dev] " Chao Yu
2021-06-17 3:45 ` Sun Ke
2021-06-17 23:46 ` Chao Yu
2021-06-18 2:03 ` Sun Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611112211.1408767-1-sunke32@huawei.com \
--to=sunke32@huawei.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox