Re: [PATCH 05/13] fstests: move test group info to test files

Eric Biggers
2021-06-16T20:53:33Z

On Mon, Jun 14, 2021 at 01:59:26PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Refactor every test in the entire test suite to use the new boilerplate
> functions. This also migrates all the test group information into the
> test files. This patch has been autogenerated via the command:
>
> ./tools/convert-group btrfs ceph cifs ext4 f2fs generic nfs ocfs2 overlay perf shared udf xfs
>
> NOTE: This patch submission only contains diffs of the first seven btrfs
> tests because vger rejects 1.5MB patches. The full conversion is in the
> git branch linked from the cover letter.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

Looks good, thanks for doing this! I can't review the whole commit, but the
changes to the tests I've written look fine, and they still run and pass. Also
I verified that the diff matches that produced by convert-group, as claimed.

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric