From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
fstests@vger.kernel.org, Sun Ke <sunke32@huawei.com>,
Yang Xu <xuyang2018.jy@fujitsu.com>,
Theodore Ts'o <tytso@mit.edu>, Zorro Lang <zlang@redhat.com>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [ANNOUNCE] fstests: master branch updated to 73030114397b
Date: Sun, 27 Jun 2021 22:01:23 -0700 [thread overview]
Message-ID: <20210628050123.GA13767@locust> (raw)
In-Reply-To: <20210628010240.GN2419729@dread.disaster.area>
On Mon, Jun 28, 2021 at 11:02:40AM +1000, Dave Chinner wrote:
> On Sun, Jun 27, 2021 at 11:33:54PM +0800, Eryu Guan wrote:
> > Hi all,
> >
> > The master branch of the xfstests repository at:
> >
> > git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
> >
> > have just been updated. The only thing in this update is the "move test group
> > lists into test files" patchset from Darrick J. Wong, which moves each test's
> > group information into the test itself, and automatically generate the group
> > files as part of the make process. Please refer to the description quated from
> > Darrick's PR cover letter below [1].
> >
> > This may break some old habits while using fstests, some heads up below
> ....
> > And this update probably may introduce regressions and bugs, please help report
> > and/or fix bugs if you hit any.
>
> Yup, generic/019 is the first regression I've noticed:
>
> generic/019 46s ... - output mismatch (see
> /home/dave/src/xfstests-dev/results//xfs/generic/019.out.bad)
> --- tests/generic/019.out 2014-04-08 09:43:28.506999723 +1000
> +++ /home/dave/src/xfstests-dev/results//xfs/generic/019.out.bad
> 2021-06-28 10:39:30.653077176 +1000
> @@ -7,3 +7,5 @@
> Force SCRATCH_DEV device failure
> Make SCRATCH_DEV device operable again
> Disallow global fail_make_request feature
> +/home/dave/src/xfstests-dev/tests/generic/019: line 56: poweron_scratch_dev: command not found
> +Disallow global fail_make_request feature
> ...
> (Run 'diff -u /home/dave/src/xfstests-dev/tests/generic/019.out /home/dave/src/xfstests-dev/results//xfs/generic/019.out.bad' to see the entire diff)
>
> I suspect that _cleanup output on EXIT is now being captured to the
> $seq.out file, because I can't see how this _cleanup function ever
> worked - poweron_scratch_dev() doesn't exist and AFAICT it never
> has....
Yeah, I noticed that this test has been busted forever. :(
The test also probably needs to ulimit -c 0 so that fstests won't
complain about corefiles when fio dies after the fs goes down.
--D
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
prev parent reply other threads:[~2021-06-28 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 15:33 [ANNOUNCE] fstests: master branch updated to 73030114397b Eryu Guan
2021-06-28 1:02 ` Dave Chinner
2021-06-28 5:01 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628050123.GA13767@locust \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=jlayton@kernel.org \
--cc=sunke32@huawei.com \
--cc=tytso@mit.edu \
--cc=xuyang2018.jy@fujitsu.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox