From: "Darrick J. Wong" <djwong@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: fix g/019 cleanup
Date: Tue, 29 Jun 2021 14:08:03 -0700 [thread overview]
Message-ID: <20210629210803.GE13767@locust> (raw)
In-Reply-To: <20210629005500.1687804-1-david@fromorbit.com>
On Tue, Jun 29, 2021 at 10:55:00AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> This never worked properly and the failure was exposed by the recent
> rework of the fstest setup infrastructure.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks fine, and I have further cleanups for this test :P
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/generic/019 | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/generic/019 b/tests/generic/019
> index 640c96ae..bd234815 100755
> --- a/tests/generic/019
> +++ b/tests/generic/019
> @@ -53,7 +53,6 @@ stop_fail_scratch_dev()
> # Override the default cleanup function.
> _cleanup()
> {
> - poweron_scratch_dev
> disallow_fail_make_request
> rm -f $tmp.*
> }
> @@ -156,5 +155,4 @@ _scratch_mount
> allow_fail_make_request
> _workout
> status=$?
> -disallow_fail_make_request
> exit
> --
> 2.31.1
>
prev parent reply other threads:[~2021-06-29 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 0:55 [PATCH] fstests: fix g/019 cleanup Dave Chinner
2021-06-29 21:08 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629210803.GE13767@locust \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox