From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C450CC11F65 for ; Wed, 30 Jun 2021 15:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FE8F61477 for ; Wed, 30 Jun 2021 15:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235822AbhF3PyT (ORCPT ); Wed, 30 Jun 2021 11:54:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235726AbhF3PyT (ORCPT ); Wed, 30 Jun 2021 11:54:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AE3D5611CA; Wed, 30 Jun 2021 15:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625068310; bh=7fhf6pxUaSFPwZo50RxCo5ZCrh3FKIYAtt1Da5hj71U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pUySNyTxHDI1iiQSxUcfoQPYKNDrn8ufSTuTj2Bf93zvp5F0m4wsioKZvLDqXAFcx KuTqdVwo/io0G3CcIfRcIBJ2xZ+MAlxHj19bIgsPJjVpBhbTfz2MXe8PIy/yTy34iG 4Srv/tjXZLubB8UIh4Q+VcAVt4nT8ZNGnZXuYo+5C5V2saOagm11lTwFiMRjg6cmfB NEQeMCMcxMgr9CIYr+5uwYzEVACyDBCclAxU42nKg5/gE32IfTP3lFm19QGmmt7qBr ethFX0wR4sTd8Ls6KecTlA6Wjcit18FK9vrYmLKhRRfTB/ucqTEMVfHu2KERWRCI9Q /W4l5NIlol/lA== Date: Wed, 30 Jun 2021 08:51:50 -0700 From: "Darrick J. Wong" To: Ritesh Harjani Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 9/9] common/attr: Reduce MAX_ATTRS to leave some overhead for 64K blocksize Message-ID: <20210630155150.GC13743@locust> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Mon, Jun 14, 2021 at 11:58:13AM +0530, Ritesh Harjani wrote: > Test generic/020 fails for ext4 with 64K blocksize. So increase some overhead > value to reduce the MAX_ATTRS so that it can accomodate for 64K blocksize. > > Signed-off-by: Ritesh Harjani > --- > common/attr | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/attr b/common/attr > index d3902346..e8661d80 100644 > --- a/common/attr > +++ b/common/attr > @@ -260,7 +260,7 @@ xfs|udf|pvfs2|9p|ceph|nfs) > # Assume max ~1 block of attrs > BLOCK_SIZE=`_get_block_size $TEST_DIR` > # user.attribute_XXX="value.XXX" is about 32 bytes; leave some overhead > - let MAX_ATTRS=$BLOCK_SIZE/40 > + let MAX_ATTRS=$BLOCK_SIZE/48 50% is quite a lot of overhead; maybe we should special-case this? --D > esac > > export MAX_ATTRS > -- > 2.31.1 >