Re: [PATCH 0/2] skip tests that don't work with an external log

Darrick J. Wong
2021-07-06T17:48:38Z

On Mon, Jul 05, 2021 at 12:03:05AM -0400, Theodore Ts'o wrote:
> I recently tried running xfstests with an external log device, and
> found a number of failures caused by the fact that we use dmflakey and
> dmerror to take down a disk to simulate a power failure or a complete
> hard disk failure. But with an external log device, the tests don't
> correctly simulate these scenarios, so skip them.

Counter-proposal: If I sent out my series to fix all that[1], would you
review them?

--D

[1] https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=dmerror-on-rt-devices

>
> With these patches, testing with ext4 using an external log is passing
> almost all of the auto group tests, with the exception of ext4/028
> (which appears to be a genuine ext4 fsmap bug not handling external
> log devices correctly).
>
> Theodore Ts'o (2):
> dmflakey: don't run dmflakey tests with an external log device
> generic/475: skip test when using an external log device
>
> common/dmflakey | 4 ++++
> tests/generic/475 | 4 ++++
> 2 files changed, 8 insertions(+)
>
> --
> 2.31.0
>