From: Pavel Reichl <preichl@redhat.com>
To: fstests@vger.kernel.org
Subject: [PATCH v2 1/1] generic/{453,454}: Don't run for FSs restricting names
Date: Thu, 8 Jul 2021 00:32:27 +0200 [thread overview]
Message-ID: <20210707223227.32053-2-preichl@redhat.com> (raw)
In-Reply-To: <20210707223227.32053-1-preichl@redhat.com>
Running generic/{453,454} tests is probably only useful for filesystems
that allow unrestricted byte streams for names.
Signed-off-by: Pavel Reichl <preichl@redhat.com>
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
---
common/rc | 13 +++++++++++++
tests/generic/453 | 1 +
tests/generic/454 | 1 +
3 files changed, 15 insertions(+)
diff --git a/common/rc b/common/rc
index d4ad421e..8ebe93c4 100644
--- a/common/rc
+++ b/common/rc
@@ -4599,6 +4599,19 @@ _require_od_endian_flag()
_notrun "od does not support endian flag"
}
+# Skip this test unless the filesystem treats names (directory entries,
+# fs labels, and extended attribute names) as raw byte sequences.
+_require_names_are_bytes() {
+ case "$FSTYP" in
+ ext2|ext3|ext4|xfs|btrfs)
+ # do nothing
+ ;;
+ *)
+ _notrun "$FSTYP does not allow unrestricted byte streams for names"
+ ;;
+ esac
+}
+
init_rc
################################################################################
diff --git a/tests/generic/453 b/tests/generic/453
index 55ddcc01..a0fb802e 100755
--- a/tests/generic/453
+++ b/tests/generic/453
@@ -15,6 +15,7 @@ _begin_fstest auto quick dir
# Import common functions.
_require_scratch
+_require_names_are_bytes
echo "Format and mount"
_scratch_mkfs > $seqres.full 2>&1
diff --git a/tests/generic/454 b/tests/generic/454
index 3aefa9f0..133e2e9d 100755
--- a/tests/generic/454
+++ b/tests/generic/454
@@ -17,6 +17,7 @@ _begin_fstest auto quick attr
_require_scratch
_require_attrs
+_require_names_are_bytes
echo "Format and mount"
_scratch_mkfs > $seqres.full 2>&1
--
2.31.1
next prev parent reply other threads:[~2021-07-07 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 22:32 [PATCH v2 0/1] generic/{453,454}: Do NOT run for FSs restricting names Pavel Reichl
2021-07-07 22:32 ` Pavel Reichl [this message]
2021-07-08 16:36 ` Pavel Reichl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210707223227.32053-2-preichl@redhat.com \
--to=preichl@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox