Re: [PATCH] generic/459: catch mount failure

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, Jul 09, 2021 at 04:10:27PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Because if we don't, we freeze the root filesystem instead of
> $SCRATCH_MNT and it all goes downhill from there.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Heh, more mount failure whackamole. :(

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/generic/459 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/generic/459 b/tests/generic/459
> index 7fd7a6fa..e5e5e9ab 100755
> --- a/tests/generic/459
> +++ b/tests/generic/459
> @@ -77,7 +77,9 @@ _mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
>  $LVM_PROG lvcreate  -k n -s $vgname/$lvname \
>  		    -n $snapname >>$seqres.full 2>&1
>  
> -_mount /dev/mapper/$vgname-$snapname $SCRATCH_MNT
> +# Catch mount failure so we don't blindly go an freeze the root filesystem
> +# instead of lvm volume.
> +_mount /dev/mapper/$vgname-$snapname $SCRATCH_MNT || _fail "mount failed"
>  
>  # Consume all space available in the volume and freeze to ensure everything
>  # required to make the fs consistent is flushed to disk.
> -- 
> 2.31.1
>