Re: [PATCH 4/6] xfs/220: avoid failure when disabling quota accounting is not supported

Christoph Hellwig
2021-07-20T06:37:57Z

On Wed, Jul 14, 2021 at 04:30:49PM -0700, Darrick J. Wong wrote:
> > +#
> > +# The sed expression below replaces a notrun to cater for kernels that have
> > +# removed the ability to disable quota accounting at runtime. On those
> > +# kernel this test is rather useless, and in a few years we can drop it.
> > +xfs_quota -x -c off -c remove $SCRATCH_DEV 2>&1 | \
>
> Please replace 'xfs_quota' with '$XFS_QUOTA_PROG' in all these tests
> you're touching.
>
> > + sed -e '/XFS_QUOTARM: Invalid argument/d'
>
> Between 'off' and 'remove', which one returned EINVAL?

remove, as the file system is still using the quota files.