public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Hao Xu <haoxu@linux.alibaba.com>
To: fstests@vger.kernel.org
Cc: Frank van der Linden <fllinden@amazon.com>
Subject: [PATCH] common/attr: remove the MAX_ATTRS and MAX_ATTRVAL_SIZE for nfs
Date: Wed,  4 Aug 2021 15:41:48 +0800	[thread overview]
Message-ID: <20210804074148.203065-1-haoxu@linux.alibaba.com> (raw)

The block size of localfs for nfs may be different with nfs itself.
So it's pointless to test nfs on xattrs size, just remove the special
judge code.

Fixes: commit da3cdb3b91ca ("common/attr: set MAX_ATTR values correctly for NFS")
Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
---
 common/attr | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/attr b/common/attr
index 42ceab92335a..542dff34bf55 100644
--- a/common/attr
+++ b/common/attr
@@ -253,7 +253,7 @@ _getfattr()
 
 # set maximum total attr space based on fs type
 case "$FSTYP" in
-xfs|udf|pvfs2|9p|ceph|nfs)
+xfs|udf|pvfs2|9p|ceph)
 	MAX_ATTRS=1000
 	;;
 *)
@@ -273,7 +273,7 @@ xfs|udf|btrfs)
 pvfs2)
 	MAX_ATTRVAL_SIZE=8192
 	;;
-9p|ceph|nfs)
+9p|ceph)
 	MAX_ATTRVAL_SIZE=65536
 	;;
 bcachefs)
-- 
2.24.4


             reply	other threads:[~2021-08-04  7:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  7:41 Hao Xu [this message]
2021-08-04 16:48 ` [PATCH] common/attr: remove the MAX_ATTRS and MAX_ATTRVAL_SIZE for nfs Frank van der Linden
2021-08-08 13:41 ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210804074148.203065-1-haoxu@linux.alibaba.com \
    --to=haoxu@linux.alibaba.com \
    --cc=fllinden@amazon.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox