From: Christian Brauner <christian.brauner@ubuntu.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>,
fstests@vger.kernel.org, Eryu Guan <guan@eryu.me>
Subject: Re: [PATCH v2 1/6] idmapped-mounts: prepare for additional tests
Date: Tue, 10 Aug 2021 16:03:31 +0200 [thread overview]
Message-ID: <20210810140331.irdmzpny7ro52lap@wittgenstein> (raw)
In-Reply-To: <20210810081549.GA20012@lst.de>
On Tue, Aug 10, 2021 at 10:15:49AM +0200, Christoph Hellwig wrote:
> On Sat, Jul 31, 2021 at 06:58:29PM +0200, Christian Brauner wrote:
> > From: Christian Brauner <christian.brauner@ubuntu.com>
> >
> > - Use sequential option numbering for option parsing since we're only
> > using longopts anyway and to easier correlate test parsing in the
> > switch with the options specified in longopts.
>
> These sequential options are rally weird. Why not use getopt_long_only?
Good point! Let me see if I can make that work.
>
> >
> > - Introduce an explicit command line switch to runs the basic test
> > suite. This prepares for the introduction of additional command line
> > switches to run tests.
> > - Update help output.
> > - Use die() when logging test failure.
>
> Each of these changes really should be a separate patch.
Ok, will split this up.
Thanks for the reviews, much appreciated!
Christian
next prev parent reply other threads:[~2021-08-10 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 16:58 [PATCH v2 0/6] Extend idmapped mount testsuite Christian Brauner
2021-07-31 16:58 ` [PATCH v2 1/6] idmapped-mounts: prepare for additional tests Christian Brauner
2021-08-10 8:15 ` Christoph Hellwig
2021-08-10 14:03 ` Christian Brauner [this message]
2021-07-31 16:58 ` [PATCH v2 2/6] generic/640: add fscaps regression test Christian Brauner
2021-08-10 8:17 ` Christoph Hellwig
2021-07-31 16:58 ` [PATCH v2 3/6] idmapped-mounts: refactor helpers Christian Brauner
2021-08-10 8:18 ` Christoph Hellwig
2021-07-31 16:58 ` [PATCH v2 4/6] idmapped-mounts: add nested userns creation helpers Christian Brauner
2021-08-10 8:18 ` Christoph Hellwig
2021-07-31 16:58 ` [PATCH v2 5/6] generic/641: add nested user namespace tests Christian Brauner
2021-08-10 8:20 ` Christoph Hellwig
2021-07-31 17:06 ` [PATCH v2 0/6] Extend idmapped mount testsuite Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810140331.irdmzpny7ro52lap@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=brauner@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox