Re: [PATCH] common/rc: fix MKSWAP_PROG quoting

Theodore Ts'o
2021-08-31T17:05:20Z

On Tue, Aug 31, 2021 at 09:42:07PM +0800, Zorro Lang wrote:
>
> Sorry, I reversed the order. I mean:
>
> $MKSWAP_PROG "$fname" 2>&1 >> $seqres.full | grep -v "insecure permission"

That looks right, although I might have done something like this:

filter_mkswap_stderr()
{
grep -v "insecure permission"
}

...

$MKSWAP_PROG "$fname" 2>&1 >> $seqres.full | filter_mkswap_stderr

More for the documentation effect rather than the abstraction. But I
wouldn't insist on it; some folks might consider this to be excess
levels abstraction.

- Ted