From: Luis Henriques <lhenriques@suse.de>
To: fstests@vger.kernel.org
Cc: Zorro Lang <zlang@redhat.com>, Eric Biggers <ebiggers@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>, Eryu Guan <guan@eryu.me>,
Luis Chamberlain <mcgrof@kernel.org>,
Luis Henriques <lhenriques@suse.de>
Subject: [PATCH v3 0/2] generic/079 test fails if 'nobody' and 'daemon' don't exist
Date: Mon, 27 Sep 2021 11:58:41 +0100 [thread overview]
Message-ID: <20210927105843.8661-1-lhenriques@suse.de> (raw)
Hi!
Changes since v2:
- Make the 'grep' command more accurate, i.e. make sure user 'myuser'
exists in /etc/passwd and not 'myuser123'. Suggested by Zorro Lang.
Changed since v1:
- 'user' variable in _require_user_exists() is now local, as suggested
by Eric Biggers.
(I've also added Darrick's Reviewed-by tag to the 2nd patch only.)
Original cover-letter:
Test generic/079 currently fails if for some reason the 'nobody' or
'daemon' users don't exist:
*** starting up
add_acl(/mnt/scratch/079/immutable.f) did not set errno == EPERM
add_acl(/mnt/scratch/079/immutable.d) did not set errno == EPERM
add_acl(/mnt/scratch/079/append-only.f) did not set errno == EPERM
add_acl(/mnt/scratch/079/append-only.d) did not set errno == EPERM
testing immutable...FAILED! (2 tests failed)
testing append-only...FAILED! (2 tests failed)
*** cleaning up
The first patch that follows adds a new function _require_user_exists()
that will verify a user exists in the system (and refactors existent
_require_user() to use the new function).
The second patch is the actual test fix.
Luis Henriques (2):
common/rc: add _require_user_exists() to check if a user exists
generic/079: make sure users 'nobody' and 'daemon' exist
common/rc | 27 ++++++++++++++++++---------
tests/generic/079 | 2 ++
2 files changed, 20 insertions(+), 9 deletions(-)
next reply other threads:[~2021-09-27 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 10:58 Luis Henriques [this message]
2021-09-27 10:58 ` [PATCH v3 1/2] common/rc: add _require_user_exists() to check if a user exists Luis Henriques
2021-09-27 10:58 ` [PATCH v3 2/2] generic/079: make sure users 'nobody' and 'daemon' exist Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927105843.8661-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=mcgrof@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox