public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luís Henriques" <lhenriques@suse.de>
To: fstests@vger.kernel.org
Cc: "Ming Lei" <ming.lei@redhat.com>, "Zorro Lang" <zlang@redhat.com>,
	"Theodore Ts'o" <tytso@mit.edu>, "Jens Axboe" <axboe@kernel.dk>,
	"Luís Henriques" <lhenriques@suse.de>
Subject: [PATCH] generic/095: don't use 1k blocksize for DIO operations
Date: Mon, 11 Oct 2021 14:55:04 +0100	[thread overview]
Message-ID: <20211011135504.23328-1-lhenriques@suse.de> (raw)

This test fails when using zram because it's using bs=1k for DIO in fio
jobs.  Fix the test by using _min_dio_alignment instead to get the correct
blocksize.

Signed-off-by: Luís Henriques <lhenriques@suse.de>
---
 tests/generic/095 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/generic/095 b/tests/generic/095
index c4693917b3e1..80448200bb86 100755
--- a/tests/generic/095
+++ b/tests/generic/095
@@ -23,6 +23,7 @@ iodepth_batch=$((8 * LOAD_FACTOR))
 numjobs=$((5 * LOAD_FACTOR))
 fio_config=$tmp.fio
 fio_out=$tmp.fio.out
+blksz=$(_min_dio_alignment $SCRATCH_DEV)
 cat >$fio_config <<EOF
 [global]
 bs=8k
@@ -34,7 +35,7 @@ directory=$SCRATCH_MNT
 numjobs=$numjobs
 [job1]
 ioengine=sync
-bs=1k
+bs=$blksz
 direct=1
 rw=randread
 filename=file1:file2
@@ -44,7 +45,7 @@ rw=randwrite
 direct=1
 filename=file1:file2
 [job3]
-bs=1k
+bs=$blksz
 ioengine=posixaio
 rw=randwrite
 direct=1

             reply	other threads:[~2021-10-11 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 13:55 Luís Henriques [this message]
2021-10-11 14:36 ` [PATCH] generic/095: don't use 1k blocksize for DIO operations Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011135504.23328-1-lhenriques@suse.de \
    --to=lhenriques@suse.de \
    --cc=axboe@kernel.dk \
    --cc=fstests@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=tytso@mit.edu \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox