From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7861C433EF for ; Mon, 11 Oct 2021 16:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0ED960F3A for ; Mon, 11 Oct 2021 16:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231447AbhJKQsx (ORCPT ); Mon, 11 Oct 2021 12:48:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:38300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbhJKQsw (ORCPT ); Mon, 11 Oct 2021 12:48:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9736E60F38; Mon, 11 Oct 2021 16:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633970812; bh=nKFa3KZD9Ikzexf/JYYr0UJazGcgdS80gG8MZEzgrC4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fvhedpIvcNgVH8GjBf6zj/J5YkBN+WNELRGRuUFJ2E47In9u+hYQD0jdOtlO1Z3SA k7GU+INf17U3tjq4sR/vLBbDFktobSybj0xNYtl5AbNct4Zwx4LTo/y2Hcqmrzdv2e /Gy5VbNlz7YXNYg2RW+BMyVwRDYQcZAmIOyvUW2ecKSH2om1EvfcJU3GTNdoLK3cn+ ntPR2g3rM9gUHCKdFDfB2OsT5KjwGEvCDkqmewO5kKYNLrZHwV2/PxnL+88yO0T4x5 LiFbIpjGXXcco1p/a/5d2mE+0eUGo352x8lhAbhqnYxbbsU3T7AW2rpZ17FnfqM+8Y dtlQ04o5aSJoQ== Date: Mon, 11 Oct 2021 09:46:52 -0700 From: "Darrick J. Wong" To: Anju T Sudhakar Cc: fstests@vger.kernel.org Subject: Re: [PATCH 2/4] generic/594: Fix test failure for xfs on older quota-tools Message-ID: <20211011164652.GF24282@magnolia> References: <20211011075552.196688-1-anju@linux.vnet.ibm.com> <20211011075552.196688-3-anju@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211011075552.196688-3-anju@linux.vnet.ibm.com> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Mon, Oct 11, 2021 at 01:25:50PM +0530, Anju T Sudhakar wrote: > For xfs we need the quota-tools containing commit fdd774bf08e568 > ("quota-tools: pass quota type to QCMD for Q_XFS_GETQSTAT")to run this > test. Otherwise this test will fail on xfs, as the grace time is not set > correctly. So check for the quota-tool with the required commit before > running this test on xfs. This is a regression test for a kernel bug where Q_XGETQSTAT[V] ignores the quota type that userspace specifies in the system call and instead returns information about the first enabled quotatype. It just so happens that quota-tools /also/ had a bug where it would never send the user's quota type to the kernel, so nobody noticed the nested herp and derp. The test should probably have mentioned kernel commit 555b2c3da1fc ("quota: honor quota type in Q_XGETQSTAT[V] calls") directly to make this more obvious. --D > Signed-off-by: Anju T Sudhakar > --- > tests/generic/594 | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/generic/594 b/tests/generic/594 > index 88f9a0dc..668c1fae 100755 > --- a/tests/generic/594 > +++ b/tests/generic/594 > @@ -6,6 +6,8 @@ > # > # Test per-type(user, group and project) filesystem quota timers, make sure > # each of grace time can be set/get properly. > +# For xfs, you need a quota-tools containing commit fdd774bf08e568 for this > +# test to run properly- v4.06 should do. > # > . ./common/preamble > _begin_fstest auto quick quota > @@ -18,9 +20,13 @@ _begin_fstest auto quick quota > _supported_fs generic > _require_scratch > _require_setquota_project > +version=$(setquota -V | head -n1 | cut -d" " -f4) > # V4 XFS doesn't support to mount project and group quota together > if [ "$FSTYP" = "xfs" ];then > _require_scratch_xfs_crc > + if [ "$version" \< "4.06" ];then > + _notrun "This test requires quota-tools 4.06 or greater" > + fi > fi > _require_quota > > -- > 2.24.1 >