From: Luis Chamberlain <mcgrof@kernel.org>
To: fstests@vger.kernel.org, fdmanana@gmail.com, djwong@kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Anthony Iliopoulos <ailiopoulos@suse.de>
Subject: [PATCH v3] fsstress: improve error message on check_cwd() error
Date: Fri, 5 Nov 2021 09:44:32 -0700 [thread overview]
Message-ID: <20211105164432.2860572-1-mcgrof@kernel.org> (raw)
I ran into an error with generic/083 with xfs due to check_cwd() but
why it failed is not clear because there are two types of
failures:
o stat64() failed (likely -ENOMEM is my guess)
o the inode actually changed
Throw a bone out to developers so that in case en error does happen
they know which rabbit hole to go into.
Cc: Anthony Iliopoulos <ailiopoulos@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
Changes on this v3:
o Minor nitpick on spaces
o Changed rabbit hole language
o enhanced stat64() error message to include errno as well
o cast things as suggested
ltp/fsstress.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 90ae432e..aab64f33 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -9,6 +9,7 @@
#include <sys/uio.h>
#include <stddef.h>
#include <stdbool.h>
+#include <string.h>
#include "global.h"
#ifdef HAVE_BTRFSUTIL_H
@@ -943,9 +944,22 @@ check_cwd(void)
{
#ifdef DEBUG
struct stat64 statbuf;
+ int ret;
+
+ ret = stat64(".", &statbuf);
+ if (ret != 0) {
+ fprintf(stderr, "fsstress: check_cwd stat64() returned %d with errno: %d (%s)\n",
+ ret, errno, strerror(errno));
+ goto out;
+ }
- if (stat64(".", &statbuf) == 0 && statbuf.st_ino == top_ino)
+ if (statbuf.st_ino == top_ino)
return;
+
+ fprintf(stderr, "fsstress: check_cwd statbuf.st_ino (%llu) != top_ino (%llu)\n",
+ (unsigned long long) statbuf.st_ino,
+ (unsigned long long) top_ino);
+out:
assert(chdir(homedir) == 0);
fprintf(stderr, "fsstress: check_cwd failure\n");
abort();
--
2.33.0
next reply other threads:[~2021-11-05 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 16:44 Luis Chamberlain [this message]
2021-11-05 16:50 ` [PATCH v3] fsstress: improve error message on check_cwd() error Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105164432.2860572-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=ailiopoulos@suse.de \
--cc=djwong@kernel.org \
--cc=fdmanana@gmail.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox