From: David Sterba <dsterba@suse.cz>
To: Eryu Guan <guan@eryu.me>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH] fstests: generic/260: don't fail for certain fstrim ops on btrfs
Date: Mon, 29 Nov 2021 20:32:56 +0100 [thread overview]
Message-ID: <20211129193256.GH28560@twin.jikos.cz> (raw)
In-Reply-To: <YaOeFrS/wX43Qw5c@desktop>
On Sun, Nov 28, 2021 at 11:19:50PM +0800, Eryu Guan wrote:
> On Mon, Nov 22, 2021 at 05:08:10PM -0500, Josef Bacik wrote:
> > We have always failed generic/260, because it tests to see if the file
> > system will reject a trim range that is above the reported fs size.
> > However for btrfs we will happily remap logical byte offsets within the
> > file system, so you can end up with bye offsets past the end of the
> > reported end of the file system. Thus we do not fail these weird
> > ranges. We also don't have the concept of allocation groups, so the
> > other test that tries to catch overflow doesn't apply to us either. Fix
> > this by simply using an offset that will fail (once a related kernel
> > path is applied) for btrfs. This will allow us to test the different
> > overflow cases that do apply to btrfs, and not muddy up test results by
> > giving us a false negative for the cases that do not apply to btrfs.
> >
> > Signed-off-by: Josef Bacik <josef@toxicpanda.com>
>
> I'd like an ACK from btrfs folks as well.
Ack.
prev parent reply other threads:[~2021-11-29 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 22:08 [PATCH] fstests: generic/260: don't fail for certain fstrim ops on btrfs Josef Bacik
2021-11-28 15:19 ` Eryu Guan
2021-11-29 19:32 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129193256.GH28560@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox