From: Christian Brauner <brauner@kernel.org>
To: fstests@vger.kernel.org, Eryu Guan <guan@eryu.me>
Cc: Christoph Hellwig <hch@lst.de>,
Seth Forshee <sforshee@digitalocean.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Seth Forshee <seth.forshee@digitalocean.com>,
Eryu Guan <guaneryu@gmail.com>
Subject: [PATCH 1/3] idmapped-mounts: remove redundant fchownat() call in setgid tests
Date: Fri, 7 Jan 2022 15:44:34 +0100 [thread overview]
Message-ID: <20220107144436.332389-1-brauner@kernel.org> (raw)
From: Christian Brauner <christian.brauner@ubuntu.com>
There's another call to fchownat() right above it so we really don't
need the second one.
Cc: Seth Forshee <seth.forshee@digitalocean.com>
Cc: Eryu Guan <guaneryu@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---
src/idmapped-mounts/idmapped-mounts.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/idmapped-mounts/idmapped-mounts.c b/src/idmapped-mounts/idmapped-mounts.c
index da690779..56b26b0c 100644
--- a/src/idmapped-mounts/idmapped-mounts.c
+++ b/src/idmapped-mounts/idmapped-mounts.c
@@ -8133,11 +8133,6 @@ static int setgid_create_idmapped_in_userns(void)
goto out;
}
- if (fchownat(t_dir1_fd, "", -1, 1000, AT_SYMLINK_NOFOLLOW | AT_EMPTY_PATH)) {
- log_stderr("failure: fchownat");
- goto out;
- }
-
pid = fork();
if (pid < 0) {
log_stderr("failure: fork");
base-commit: 770f462e17e52c4b2bc026fd707ad01fcce95f32
--
2.32.0
next reply other threads:[~2022-01-07 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 14:44 Christian Brauner [this message]
2022-01-07 14:44 ` [PATCH 2/3] idmapped-mounts: add more explanations to setgid tests Christian Brauner
2022-01-07 14:44 ` [PATCH 3/3] idmapped-mounts: add missing ownership comparisons " Christian Brauner
-- strict thread matches above, loose matches on Subject: below --
2022-01-07 14:58 [PATCH 1/3] idmapped-mounts: remove redundant fchownat() call in " Christian Brauner
2022-01-10 9:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107144436.332389-1-brauner@kernel.org \
--to=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=hch@lst.de \
--cc=seth.forshee@digitalocean.com \
--cc=sforshee@digitalocean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).